Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2830903005: [Chromedriver] Ensure baseURL is 'about:blank' for dummy page on Chrome 60+. (Closed)

Created:
3 years, 8 months ago by gmanikpure
Modified:
3 years, 8 months ago
Reviewers:
johnchen, stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromedriver] Ensure baseURL is 'about:blank' for dummy page on Chrome 60+. From Chrome 60 onwards, root.baseURL will no longer be empty and will always return 'about:blank'. See crbug/711562 for more details. BUG=chromedriver:1775 Review-Url: https://codereview.chromium.org/2830903005 Cr-Commit-Position: refs/heads/master@{#467328} Committed: https://chromium.googlesource.com/chromium/src/+/0889921a392dbd9305d9e747ffd8cdf01e14a22a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M chrome/test/chromedriver/chrome/navigation_tracker.cc View 1 chunk +14 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
gmanikpure
Hi John, This CL fixes https://bugs.chromium.org/p/chromedriver/issues/detail?id=1775 To make sure there are no regressions, I tested ...
3 years, 8 months ago (2017-04-25 16:43:46 UTC) #3
johnchen
lgtm
3 years, 8 months ago (2017-04-25 23:56:08 UTC) #4
stgao
On 2017/04/25 23:56:08, johnchen wrote: > lgtm lgtm
3 years, 8 months ago (2017-04-26 00:49:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830903005/1
3 years, 8 months ago (2017-04-26 15:02:27 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 15:19:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0889921a392dbd9305d9e747ffd8...

Powered by Google App Engine
This is Rietveld 408576698