Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2830893004: Migrate IID Coupled Uses of ScopedComPtr::ReceiveVoid() to IID_PPV_ARGS (Closed)

Created:
3 years, 8 months ago by robliao
Modified:
3 years, 8 months ago
CC:
shalamov, asvitkine+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, danakj+watch_chromium.org, feature-media-reviews_chromium.org, grt+watch_chromium.org, Mikhail, miu+watch_chromium.org, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, riju_, tfarina, timvolodine, toyoshim+midi_chromium.org, vmpstr+watch_chromium.org, wanming.lin, wfh+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate IID Coupled Uses of ScopedComPtr::ReceiveVoid() to IID_PPV_ARGS BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=dalecurtis@chromium.org, reillyg@chromium.org, sdefresne@chromium.org, thakis@chromium.org Mechanical substitutions. Review-Url: https://codereview.chromium.org/2830893004 Cr-Commit-Position: refs/heads/master@{#466416} Committed: https://chromium.googlesource.com/chromium/src/+/9867f09db923dbdb754dc98242d80701c79ffc05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -38 lines) Patch
M base/win/win_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/metrics/antivirus_metrics_provider_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/win/jumplist_updater.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/update_client/background_downloader_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/generic_sensor/platform_sensor_and_provider_unittest_win.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M media/midi/midi_manager_winrt.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 25 (17 generated)
robliao
scottmg: Please review this change. Thanks!
3 years, 8 months ago (2017-04-20 17:26:47 UTC) #9
scottmg
lgtm
3 years, 8 months ago (2017-04-21 03:42:29 UTC) #10
robliao
TBR'ing owners for this mechanical substitution. dalecurtis: media/* reillyg: device/* sdefresne: components/* thakis: chrome/*
3 years, 8 months ago (2017-04-21 19:42:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830893004/1
3 years, 8 months ago (2017-04-21 19:42:49 UTC) #19
DaleCurtis
Fancy, lgtm
3 years, 8 months ago (2017-04-21 19:43:44 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9867f09db923dbdb754dc98242d80701c79ffc05
3 years, 8 months ago (2017-04-21 19:46:53 UTC) #23
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-04-21 19:49:56 UTC) #24
sdefresne
3 years, 8 months ago (2017-04-24 11:38:22 UTC) #25
Message was sent while issue was closed.
post fast lgtm

Powered by Google App Engine
This is Rietveld 408576698