Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2830883002: [MD settings] observe changes to default font size in Appearance (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[MD settings] observe changes to default font size in Appearance This CL updates the fixed font size from the Appearance section reliably. (It was previously working depending on which settings page had been visited). Also, updates the UI to remove the font size on the example of the fixed font size. BUG=671562 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817243003 Cr-Commit-Position: refs/heads/master@{#465054} (cherry picked from commit b7cd6a5130a7a261ae997c5e37dc4fec4560cff3) Review-Url: https://codereview.chromium.org/2830883002 . Cr-Commit-Position: refs/branch-heads/3071@{#64} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f0f4366ae4a82c833071ef05f4bc72503119c0af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -41 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js View 4 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 4 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dschuyler
3 years, 8 months ago (2017-04-19 20:32:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0f4366ae4a82c833071ef05f4bc72503119c0af.

Powered by Google App Engine
This is Rietveld 408576698