Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3377)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java

Issue 2830843004: Update to newer Android Lint and suppress new Lint errors (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
index 0ec3406b75ce1c8850f42ad7894eb8019a422b14..b66604e55cb8e9ea5c267863365c7d14ddae2c63 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser;
+import android.annotation.SuppressLint;
import android.content.Context;
import android.content.SharedPreferences;
import android.os.AsyncTask;
@@ -69,6 +70,8 @@ public class DeferredStartupHandler {
private static final String SNAPSHOT_DATABASE_NAME = "snapshots.db";
private static class Holder {
+ // TODO(crbug.com/635567): Fix this properly.
Ted C 2017/04/27 19:02:47 same comment, this is correct and no fix is needed
F 2017/04/28 18:25:14 Done.
+ @SuppressLint("StaticFieldLeak")
private static final DeferredStartupHandler INSTANCE = new DeferredStartupHandler();
}
@@ -93,6 +96,8 @@ public class DeferredStartupHandler {
sDeferredStartupHandler = handler;
}
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("StaticFieldLeak")
private static DeferredStartupHandler sDeferredStartupHandler;
protected DeferredStartupHandler() {

Powered by Google App Engine
This is Rietveld 408576698