Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2830803002: DevTools: Fast resize styles sidebar (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Throttle StylesSidebar layout updates Throttles height changes in property sections while editing. Throttles width changes in property sections on resize. BUG=684341 Review-Url: https://codereview.chromium.org/2830803002 Cr-Commit-Position: refs/heads/master@{#466062} Committed: https://chromium.googlesource.com/chromium/src/+/576dc51777e5447b043f45eb72bc54c9a7acf222

Patch Set 1 #

Patch Set 2 : Throttle editing #

Patch Set 3 : doc #

Total comments: 4

Patch Set 4 : removeProperty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 3 12 chunks +53 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/elementsPanel.css View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
einbinder
ptal
3 years, 8 months ago (2017-04-19 19:48:08 UTC) #3
pfeldman
lgtm https://codereview.chromium.org/2830803002/diff/40001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2830803002/diff/40001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1599 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1599: this.element.style.height = ''; .removeProperty https://codereview.chromium.org/2830803002/diff/40001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1600 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1600: this.element.style.contain = ...
3 years, 8 months ago (2017-04-19 19:59:22 UTC) #4
einbinder
https://codereview.chromium.org/2830803002/diff/40001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2830803002/diff/40001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode1599 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:1599: this.element.style.height = ''; On 2017/04/19 at 19:59:21, pfeldman wrote: ...
3 years, 8 months ago (2017-04-20 16:25:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830803002/60001
3 years, 8 months ago (2017-04-20 16:26:09 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 17:55:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/576dc51777e5447b043f45eb72bc...

Powered by Google App Engine
This is Rietveld 408576698