Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2830793004: Revert of [LayoutNG] Re-enable virtual/layout_ng/ (Closed)

Created:
3 years, 8 months ago by mithro
Modified:
3 years, 8 months ago
Reviewers:
tkent, kojii, qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [LayoutNG] Re-enable virtual/layout_ng/ (patchset #2 id:20001 of https://codereview.chromium.org/2822683002/ ) Reason for revert: This change causes tests to run on multiple shards. Original issue's description: > [LayoutNG] Re-enable virtual/layout_ng/ > > This was re-enabled in r464517[1] but wasn't really enabled due to > incorrect directory name. > > This patch also fixes test runner to find reference files from > MANIFEST.json for virtual test suites. > > [1] https://chromium-review.googlesource.com/c/474177/ > > BUG=636993, 706118 > > Review-Url: https://codereview.chromium.org/2822683002 > Cr-Commit-Position: refs/heads/master@{#464705} > Committed: https://chromium.googlesource.com/chromium/src/+/fc7300a1028fff4c528fa32f1529a3e8cbb1998f TBR=qyearsley@chromium.org,tkent@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636993, 706118

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
mithro
Created Revert of [LayoutNG] Re-enable virtual/layout_ng/
3 years, 8 months ago (2017-04-20 05:40:55 UTC) #1
kojii
Thank you tansell. Could you mind to explain a bit more what the problem is, ...
3 years, 8 months ago (2017-04-20 06:58:35 UTC) #2
mithro
On 2017/04/20 06:58:35, kojii wrote: > Thank you tansell. > > Could you mind to ...
3 years, 8 months ago (2017-04-20 07:53:38 UTC) #3
kojii
3 years, 8 months ago (2017-04-20 23:49:14 UTC) #4
Message was sent while issue was closed.
Oh, ok, so this didn't land. Thank you and sorry for the trouble in the other
CL.

Powered by Google App Engine
This is Rietveld 408576698