[LayoutNG] Re-enable virtual/layout_ng/

[LayoutNG] Re-enable virtual/layout_ng/

This was re-enabled in r464517[1] but wasn't really enabled due to
incorrect directory name.

This patch also fixes test runner to find reference files from
MANIFEST.json for virtual test suites.

[1] https://chromium-review.googlesource.com/c/474177/

BUG=636993, 706118
Review-Url: https://codereview.chromium.org/2822683002
Cr-Commit-Position: refs/heads/master@{#464705}
Committed: https://chromium.googlesource.com/chromium/src/+/fc7300a1028fff4c528fa32f1529a3e8cbb1998f

[kojii, 2017-04-14 06:25:48]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 06:26:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-04-14 06:27:38]

Description was changed from

==========
ngtest

BUG=
==========

to

==========
[LayoutNG] Re-enable virtual/layout_ng/

This was re-enabled in r464517[1] but wasn't really enabled due to
incorrect directory name.

This patch also fixes test runner to find reference files from
MANIFEST.json for virtual test suites.

[1] https://chromium-review.googlesource.com/c/474177/

BUG=636993, 706118
==========

[kojii, 2017-04-14 06:28:03]

kojii@chromium.org changed reviewers:
+ qyearsley@chromium.org, tkent@chromium.org

[kojii, 2017-04-14 06:28:03]

PTAL.

[tkent, 2017-04-14 06:58:32]

The code change looks ok.

https://codereview.chromium.org/2822683002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
(right):

https://codereview.chromium.org/2822683002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py:667: match =
re.match(r'virtual/[^/]+/', test_name)
Please add a test case for virtual/ in test_reference_files_from_manifest() of
base_unittest.py.

[commit-bot: I haz the power, 2017-04-14 07:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 07:26:15]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-04-14 08:02:24]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 08:02:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-04-14 08:02:59]

https://codereview.chromium.org/2822683002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
(right):

https://codereview.chromium.org/2822683002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py:667: match =
re.match(r'virtual/[^/]+/', test_name)
On 2017/04/14 at 06:58:32, tkent wrote:
> Please add a test case for virtual/ in test_reference_files_from_manifest() of
base_unittest.py.

Done, thank you for the detailed support!

[tkent, 2017-04-14 08:14:54]

lgtm

[kojii, 2017-04-14 08:17:48]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2017-04-14 08:17:50]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-04-14 08:17:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 09:03:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492157870083870,
"parent_rev": "84a4076552ec07d239ebe7032e56ccba36b26286", "commit_rev":
"fc7300a1028fff4c528fa32f1529a3e8cbb1998f"}

[commit-bot: I haz the power, 2017-04-14 09:03:48]

Description was changed from

==========
[LayoutNG] Re-enable virtual/layout_ng/

This was re-enabled in r464517[1] but wasn't really enabled due to
incorrect directory name.

This patch also fixes test runner to find reference files from
MANIFEST.json for virtual test suites.

[1] https://chromium-review.googlesource.com/c/474177/

BUG=636993, 706118
==========

to

==========
[LayoutNG] Re-enable virtual/layout_ng/

This was re-enabled in r464517[1] but wasn't really enabled due to
incorrect directory name.

This patch also fixes test runner to find reference files from
MANIFEST.json for virtual test suites.

[1] https://chromium-review.googlesource.com/c/474177/

BUG=636993, 706118

Review-Url: https://codereview.chromium.org/2822683002
Cr-Commit-Position: refs/heads/master@{#464705}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc7300a1028fff4c528fa32f1529...
==========

[commit-bot: I haz the power, 2017-04-14 09:03:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc7300a1028fff4c528fa32f1529...

[qyearsley, 2017-04-14 21:00:00]

LGTM, thanks!

[mithro, 2017-04-20 05:40:55]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2830793004/ by tansell@chromium.org.

The reason for reverting is: This change causes tests to run on multiple
shards..