Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 2830773002: DevTools: recognize CSSIdentifiers that start with double hyphen (Closed)

Created:
3 years, 8 months ago by luoe
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: recognize CSSIdentifiers that start with double hyphen The CSS parser actually recognizes invalid CSSIdentifiers such as "--foo", even though this differs from the spec. This CL let's DevTools recognize these as selectors starting with "--" as identifiers that do not need escaping. BUG=680139 Review-Url: https://codereview.chromium.org/2830773002 Cr-Commit-Position: refs/heads/master@{#465851} Committed: https://chromium.googlesource.com/chromium/src/+/188903bc2a2e56080286ad0970605d590feffbb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/inspector/elements/elements-css-path.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-css-path-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
luoe
Please take a look
3 years, 8 months ago (2017-04-19 18:25:31 UTC) #3
lushnikov
lgtm
3 years, 8 months ago (2017-04-19 20:42:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830773002/1
3 years, 8 months ago (2017-04-20 00:02:08 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 01:38:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/188903bc2a2e56080286ad097060...

Powered by Google App Engine
This is Rietveld 408576698