Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: headless/public/util/generic_url_request_job.h

Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless (Closed)
Patch Set: Changes for Sami and creis@ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/util/generic_url_request_job.h
diff --git a/headless/public/util/generic_url_request_job.h b/headless/public/util/generic_url_request_job.h
index 8830934e3f9d9b34fc31e50f7158ac327808157e..f4e458151a32d463b22aafc2a738c30f0c97551e 100644
--- a/headless/public/util/generic_url_request_job.h
+++ b/headless/public/util/generic_url_request_job.h
@@ -31,6 +31,7 @@ class ResourceRequestInfo;
namespace headless {
+class HeadlessBrowserContext;
class URLRequestDispatcher;
// Wrapper around net::URLRequest with helpers to access select metadata.
@@ -154,11 +155,14 @@ class HEADLESS_EXPORT GenericURLRequestJob
// NOTE |url_request_dispatcher| and |delegate| must outlive the
// GenericURLRequestJob.
- GenericURLRequestJob(net::URLRequest* request,
- net::NetworkDelegate* network_delegate,
- URLRequestDispatcher* url_request_dispatcher,
- std::unique_ptr<URLFetcher> url_fetcher,
- Delegate* delegate);
+ // TODO(alexclarke): Remove the default parameter.
+ GenericURLRequestJob(
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate,
+ URLRequestDispatcher* url_request_dispatcher,
+ std::unique_ptr<URLFetcher> url_fetcher,
+ Delegate* delegate,
+ HeadlessBrowserContext* headless_browser_context = nullptr);
~GenericURLRequestJob() override;
// net::URLRequestJob implementation:
@@ -212,6 +216,7 @@ class HEADLESS_EXPORT GenericURLRequestJob
scoped_refptr<base::SingleThreadTaskRunner> origin_task_runner_;
std::unique_ptr<MockResponseData> mock_response_;
Delegate* delegate_; // Not owned.
+ HeadlessBrowserContext* headless_browser_context_; // Not owned.
const content::ResourceRequestInfo* request_resource_info_; // Not owned.
const char* body_ = nullptr; // Not owned.
size_t body_size_ = 0;

Powered by Google App Engine
This is Rietveld 408576698