Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless (Closed)
Patch Set: Changes for Sami and creis@ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
index 2e2a503fdbf466bfff7842f56f5207405c426db9..12885f44bd99fa0b0ce11609677502cc8afd17fb 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
@@ -39,6 +39,7 @@
#include "core/dom/Document.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h"
+#include "core/frame/LocalFrameClient.h"
#include "core/frame/Settings.h"
#include "core/frame/VisualViewport.h"
#include "core/html/HTMLFrameOwnerElement.h"
@@ -689,7 +690,9 @@ bool InspectorPageAgent::ScreencastEnabled() {
}
void InspectorPageAgent::FrameStartedLoading(LocalFrame* frame, FrameLoadType) {
- GetFrontend()->frameStartedLoading(FrameId(frame));
+ String frame_id = FrameId(frame);
+ GetFrontend()->frameStartedLoading(frame_id);
+ frame->Client()->SetDevToolsFrameId(frame_id);
dgozman 2017/04/25 22:04:48 Let's do this in FrameAttachedToParent - it comes
alex clarke (OOO till 29th) 2017/04/26 14:19:54 I tried doing that, the problem is the main frame
}
void InspectorPageAgent::FrameStoppedLoading(LocalFrame* frame) {

Powered by Google App Engine
This is Rietveld 408576698