third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp - Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless (Closed)

Patch Set: Add include for msvc Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

index 428dba6e34f0fefdac734d1683be889c1604841c..e173834fba7c51e4021fe8801e5fe37e0f26eaeb 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

@@ -39,6 +39,7 @@

#include "core/dom/Document.h"

#include "core/frame/FrameView.h"

#include "core/frame/LocalFrame.h"

+#include "core/frame/LocalFrameClient.h"

#include "core/frame/Settings.h"

#include "core/frame/VisualViewport.h"

#include "core/html/HTMLFrameOwnerElement.h"

@@ -699,7 +700,9 @@ bool InspectorPageAgent::ScreencastEnabled() {

}

void InspectorPageAgent::FrameStartedLoading(LocalFrame* frame, FrameLoadType) {

- GetFrontend()->frameStartedLoading(FrameId(frame));

+ String frame_id = FrameId(frame);

+ GetFrontend()->frameStartedLoading(frame_id);

+ frame->Client()->SetDevToolsFrameId(frame_id);

}

void InspectorPageAgent::FrameStoppedLoading(LocalFrame* frame) {