Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: headless/public/headless_web_contents.h

Issue 2830753004: Pipe the devTools FrameId from blink into the browser for headless (Closed)
Patch Set: Add include for msvc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/headless_web_contents.h
diff --git a/headless/public/headless_web_contents.h b/headless/public/headless_web_contents.h
index 031045f0e964221915b32bcbeddf7523912b10ea..30e9de5058a046fc5bdf84f3dd10236482394169 100644
--- a/headless/public/headless_web_contents.h
+++ b/headless/public/headless_web_contents.h
@@ -77,10 +77,16 @@ class HEADLESS_EXPORT HeadlessWebContents {
// Returns the frame tree node id associated with the |devtools_agent_host_id|
// if any.
+ // TODO(alexclarke): Remove this, it doesn't work as expected.
virtual bool GetFrameTreeNodeIdForDevToolsAgentHostId(
const std::string& devtools_agent_host_id,
int* frame_tree_node_id) const = 0;
+ // Returns the devtools frame id corresponding to the |frame_tree_node_id|, if
+ // any. Note this only works after we have received the data from blink.
Sami 2017/04/24 19:54:05 nit: "after we have received the data from blink"
alex clarke (OOO till 29th) 2017/04/25 15:01:03 Done.
+ virtual std::string GetDevToolsFrameIdForFrameTreeNodeId(
Sami 2017/04/24 19:54:05 Could we put this (and the new method on HeadlessW
alex clarke (OOO till 29th) 2017/04/25 15:01:03 Done.
+ int frame_tree_node_id) const = 0;
+
private:
friend class HeadlessWebContentsImpl;
HeadlessWebContents() {}

Powered by Google App Engine
This is Rietveld 408576698