Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2830733002: We cannot use relative URIs to reference files outside of a package. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

We cannot use relative URIs to reference files outside of a package. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/91d6dcf9fb74d3576e006d791aee35820ffa49c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 4 chunks +38 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-19 17:03:35 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-19 17:06:58 UTC) #2
scheglov
3 years, 8 months ago (2017-04-19 17:09:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91d6dcf9fb74d3576e006d791aee35820ffa49c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698