Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(249)

Issue 2830723003: Ignore fired timer if the object wrapper is no longer alive (Closed)

Created:
2 years, 9 months ago by junwei
Modified:
2 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore fired timer if the object wrapper is no longer alive CL [1] has prevented gin from recreating wrappers after GC, so doesn't fire timer if its wrapper is empty otherwise it will be crashed. [1] https://chromium-review.googlesource.com/475077 BUG=707689 Review-Url: https://codereview.chromium.org/2830723003 Cr-Commit-Position: refs/heads/master@{#466314} Committed: https://chromium.googlesource.com/chromium/src/+/bb89503baf314afded40d6517c8e6e18f1f89b6b

Patch Set 1 : Ignore fired timer if the object wrapper is no longer alive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M gin/modules/timer.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
junwei
PTAL.
2 years, 9 months ago (2017-04-20 11:51:18 UTC) #2
Ken Rockot(use gerrit already)
Lgtm but I don't own this code
2 years, 9 months ago (2017-04-20 14:22:39 UTC) #3
junwei
Jochen@ PTAL.
2 years, 9 months ago (2017-04-21 00:25:40 UTC) #5
jochen (gone - plz use gerrit)
lgtm
2 years, 9 months ago (2017-04-21 08:41:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830723003/20001
2 years, 9 months ago (2017-04-21 11:32:08 UTC) #18
commit-bot: I haz the power
2 years, 9 months ago (2017-04-21 11:36:18 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bb89503baf314afded40d6517c8e...

Powered by Google App Engine
This is Rietveld 408576698