[webnfc] Add WebNFC feature flag

[webnfc] Add WebNFC feature flag

This CL adds WebNFC feature flag, so that API access can be controlled
separately from other experimental web platform features. This would
enable feature control during origin-trial process.

BUG=520391
Review-Url: https://codereview.chromium.org/2830643002
Cr-Commit-Position: refs/heads/master@{#465992}
Committed: https://chromium.googlesource.com/chromium/src/+/588eca456e606a5697043317e5d777fad880c6f8

[shalamov, 2017-04-19 10:42:32]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 10:43:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 12:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 12:25:14]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[shalamov, 2017-04-19 13:34:11]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 13:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shalamov, 2017-04-19 14:20:33]

alexander.shalamov@intel.com changed reviewers:
+ asvitkine@chromium.org, jochen@chromium.org, reillyg@chromium.org

[shalamov, 2017-04-19 14:20:33]

Please take a look.

[Reilly Grant (use Gerrit), 2017-04-19 15:37:50]

lgtm

[jochen (gone - plz use gerrit), 2017-04-19 15:40:23]

lgtm

[commit-bot: I haz the power, 2017-04-19 15:46:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 15:46:46]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-04-19 16:43:53]

lgtm % comments

https://codereview.chromium.org/2830643002/diff/20001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2830643002/diff/20001/content/public/common/c...
content/public/common/content_features.cc:302: #else
Nit: Add  // !defined(OS_ANDROID)

https://codereview.chromium.org/2830643002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2830643002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102216: +  <int value="741238351"
label="enable-webnfc"/>
This is not needed since you're using a base::Feature

[shalamov, 2017-04-20 07:27:55]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 07:28:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shalamov, 2017-04-20 07:30:00]

Thanks for quick review!

https://codereview.chromium.org/2830643002/diff/20001/content/public/common/c...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2830643002/diff/20001/content/public/common/c...
content/public/common/content_features.cc:302: #else
On 2017/04/19 16:43:52, Alexei Svitkine (slow) wrote:
> Nit: Add  // !defined(OS_ANDROID)

Done.

https://codereview.chromium.org/2830643002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2830643002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102216: +  <int value="741238351"
label="enable-webnfc"/>
On 2017/04/19 16:43:52, Alexei Svitkine (slow) wrote:
> This is not needed since you're using a base::Feature

Done.

[commit-bot: I haz the power, 2017-04-20 07:31:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 07:31:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shalamov, 2017-04-20 09:05:02]

The CQ bit was checked by alexander.shalamov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 09:05:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 10:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 10:41:07]

Dry run: This issue passed the CQ dry run.

[shalamov, 2017-04-20 13:27:41]

The CQ bit was checked by alexander.shalamov@intel.com

[shalamov, 2017-04-20 13:27:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
asvitkine@chromium.org, reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2830643002/#ps60001
(title: "Rebased to master")

[commit-bot: I haz the power, 2017-04-20 13:27:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 13:32:47]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492694861902030,
"parent_rev": "27d3244a31074eeef019e8955c4ecc532fa11735", "commit_rev":
"588eca456e606a5697043317e5d777fad880c6f8"}

[commit-bot: I haz the power, 2017-04-20 13:33:02]

Description was changed from

==========
[webnfc] Add WebNFC feature flag

This CL adds WebNFC feature flag, so that API access can be controlled
separately from other experimental web platform features. This would
enable feature control during origin-trial process.

BUG=520391
==========

to

==========
[webnfc] Add WebNFC feature flag

This CL adds WebNFC feature flag, so that API access can be controlled
separately from other experimental web platform features. This would
enable feature control during origin-trial process.

BUG=520391

Review-Url: https://codereview.chromium.org/2830643002
Cr-Commit-Position: refs/heads/master@{#465992}
Committed:
https://chromium.googlesource.com/chromium/src/+/588eca456e606a5697043317e5d7...
==========

[commit-bot: I haz the power, 2017-04-20 13:33:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/588eca456e606a5697043317e5d7...