Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2830633002: [turbofan] Create initial map on-demand for F.prototype. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Create initial map on-demand for F.prototype. When accessing the "prototype" property of a known JSFunction in TurboFan, we can automatically create the initial map if it hasn't been instantiated so far. This happens with hand-grown inheritance mechanisms where the base classes might not be instantiated regularly at all, but the base class constructors are only called via F.p.call from the subclass constructors. R=mstarzinger@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2830633002 Cr-Commit-Position: refs/heads/master@{#44720} Committed: https://chromium.googlesource.com/v8/v8/+/4da9be30c7a4b81c57d41af30bf0eb326bac833f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Of course do this only for constructors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-19 10:10:51 UTC) #1
Michael Starzinger
https://codereview.chromium.org/2830633002/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/2830633002/diff/1/src/compiler/js-native-context-specialization.cc#newcode832 src/compiler/js-native-context-specialization.cc:832: JSFunction::EnsureHasInitialMap(function); The function must be constructible. The following is ...
3 years, 8 months ago (2017-04-19 10:38:58 UTC) #6
Benedikt Meurer
On 2017/04/19 10:40:51, Benedikt Meurer wrote: > The CQ bit was checked by mailto:bmeurer@chromium.org to ...
3 years, 8 months ago (2017-04-19 10:41:05 UTC) #9
Benedikt Meurer
Fixed, thanks!
3 years, 8 months ago (2017-04-19 10:41:17 UTC) #10
Michael Starzinger
LGTM.
3 years, 8 months ago (2017-04-19 10:42:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830633002/20001
3 years, 8 months ago (2017-04-19 10:42:29 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 11:26:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4da9be30c7a4b81c57d41af30bf0eb326ba...

Powered by Google App Engine
This is Rietveld 408576698