Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2830603002: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/sync (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
skym
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, sync-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/sync This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters. The tool rewrites base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); In terms of the behavior change after the rewrite, the OnceCallback implementation moves out the bound argument to the target function, unlike Callback. BUG=554299 TBR=skym@chromium.org Review-Url: https://codereview.chromium.org/2830603002 Cr-Commit-Position: refs/heads/master@{#465837} Committed: https://chromium.googlesource.com/chromium/src/+/87a064f8bd3bccd5e3dabaa7ecbf8e64422ebac0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/browser/sync/glue/sync_start_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_directory_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_installer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tzik
skym: This is the c/b/sync part of http://crrev.com/2825003002/. Thanks for reviewing on the original CL. ...
3 years, 8 months ago (2017-04-19 13:24:02 UTC) #7
skym
lgtm
3 years, 8 months ago (2017-04-19 15:18:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830603002/1
3 years, 8 months ago (2017-04-20 00:47:23 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 00:56:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/87a064f8bd3bccd5e3dabaa7ecbf...

Powered by Google App Engine
This is Rietveld 408576698