Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2830583002: Rename NodeLayoutData -> NodeRenderingData (Closed)

Created:
3 years, 8 months ago by nainar
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename NodeLayoutData -> NodeRenderingData Rename NodeLayoutData -> NodeRenderingData as it captures the idea behind the object better. See here for discussion: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/style-dev/iLGP_mMZdjE/w5K1t2NCBQAJ BUG=595137 Review-Url: https://codereview.chromium.org/2830583002 Cr-Commit-Position: refs/heads/master@{#467548} Committed: https://chromium.googlesource.com/chromium/src/+/c106358057df12cec17cb43e6bb06314d47526fa

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M third_party/WebKit/Source/core/dom/ElementRareData.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 8 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 3 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.h View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (13 generated)
nainar
Simple rename patch. PTAL? Thanks!
3 years, 8 months ago (2017-04-19 06:09:25 UTC) #4
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-20 02:54:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830583002/20001
3 years, 8 months ago (2017-04-27 01:50:28 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-27 01:56:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c106358057df12cec17cb43e6bb0...

Powered by Google App Engine
This is Rietveld 408576698