Fix step timing outside range [0,1]

Fix step timing outside range [0,1]

With inputs outside the range [0,1], the steps timing function does not
match the behaviour described in
https://www.w3.org/TR/css-timing-1/#step-timing-functions,
as demonstrated by the failing
LayoutTests/external/wpt/css-timing-1/step-timing-functions-output.html.
This patch changes the step timing implementation to match the specced
algorithm.

BUG=712918
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830553002
Cr-Commit-Position: refs/heads/master@{#465835}
Committed: https://chromium.googlesource.com/chromium/src/+/dc03a50c0abe027a408aae5c72f08b10d7fbe584

[suzyh_UTC10 (ex-contributor), 2017-04-19 00:49:01]

Description was changed from

==========
Fix step timing outside range [0,1]

With inputs outside the range [0,1], the steps timing function does not
match the behaviour described in
https://www.w3.org/TR/css-timing-1/#step-timing-functions,
as demonstrated by the failing
LayoutTests/external/wpt/css-timing-1/step-timing-functions-output.html.
This patch changes the step timing implementation to match the specced
algorithm.

BUG=712918
==========

to

==========
Fix step timing outside range [0,1]

With inputs outside the range [0,1], the steps timing function does not
match the behaviour described in
https://www.w3.org/TR/css-timing-1/#step-timing-functions,
as demonstrated by the failing
LayoutTests/external/wpt/css-timing-1/step-timing-functions-output.html.
This patch changes the step timing implementation to match the specced
algorithm.

BUG=712918
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[suzyh_UTC10 (ex-contributor), 2017-04-19 00:52:12]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-04-19 00:52:22]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 00:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 00:58:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 00:58:51]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[alancutter (OOO until 2018), 2017-04-19 07:16:42]

lgtm

Does this bring us in line with Firefox?

[suzyh_UTC10 (ex-contributor), 2017-04-19 07:33:30]

suzyh@chromium.org changed reviewers:
+ ajuma@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-04-19 07:33:46]

+ajuma for cc/ OWNERS


On 2017/04/19 at 07:16:42, alancutter wrote:
> lgtm
> 
> Does this bring us in line with Firefox?

Looks like Firefox stable has the same behaviour as Chrome stable, but Firefox
nightly has the same behaviour as this patch.

[suzyh_UTC10 (ex-contributor), 2017-04-19 07:35:04]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 07:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[suzyh_UTC10 (ex-contributor), 2017-04-19 08:55:37]

On 2017/04/19 at 07:33:46, suzyh_UTC10 wrote:
> +ajuma for cc/ OWNERS
> 
> 
> On 2017/04/19 at 07:16:42, alancutter wrote:
> > lgtm
> > 
> > Does this bring us in line with Firefox?
> 
> Looks like Firefox stable has the same behaviour as Chrome stable, but Firefox
nightly has the same behaviour as this patch.

Confirmed that the fixed behaviour will be shipped in Firefox 54:
https://bugzilla.mozilla.org/show_bug.cgi?id=1332206

[commit-bot: I haz the power, 2017-04-19 09:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 09:16:26]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-04-19 14:30:20]

lgtm

[suzyh_UTC10 (ex-contributor), 2017-04-20 00:46:56]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-04-20 00:46:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2830553002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-20 00:47:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 00:53:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492649216119320,
"parent_rev": "616af64093de539709fe6be5085029a42e58fe2d", "commit_rev":
"dc03a50c0abe027a408aae5c72f08b10d7fbe584"}

[commit-bot: I haz the power, 2017-04-20 00:54:36]

Description was changed from

==========
Fix step timing outside range [0,1]

With inputs outside the range [0,1], the steps timing function does not
match the behaviour described in
https://www.w3.org/TR/css-timing-1/#step-timing-functions,
as demonstrated by the failing
LayoutTests/external/wpt/css-timing-1/step-timing-functions-output.html.
This patch changes the step timing implementation to match the specced
algorithm.

BUG=712918
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fix step timing outside range [0,1]

With inputs outside the range [0,1], the steps timing function does not
match the behaviour described in
https://www.w3.org/TR/css-timing-1/#step-timing-functions,
as demonstrated by the failing
LayoutTests/external/wpt/css-timing-1/step-timing-functions-output.html.
This patch changes the step timing implementation to match the specced
algorithm.

BUG=712918
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830553002
Cr-Commit-Position: refs/heads/master@{#465835}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc03a50c0abe027a408aae5c72f0...
==========

[commit-bot: I haz the power, 2017-04-20 00:54:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc03a50c0abe027a408aae5c72f0...