Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2830473002: Revert of Remove UpdateScrollTree (Closed)

Created:
3 years, 8 months ago by pdr.
Modified:
3 years, 8 months ago
Reviewers:
weiliangc, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove UpdateScrollTree (patchset #1 id:1 of https://codereview.chromium.org/2822603002/ ) Reason for revert: Patch failed to handle changes to scroll clip layer bounds. Original issue's description: > Remove draw_property_utils's UpdateScrollTree > > This function was added in [1] but is not needed. Removing this function > lets us remove one more user of scroll_node's owning_layer_id. > > [1] https://chromium.googlesource.com/chromium/src/+/1c0802c3c4c03b43efea23b82d7e624f1d8c7b57 > > BUG=693740 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2822603002 > Cr-Commit-Position: refs/heads/master@{#465342} > Committed: https://chromium.googlesource.com/chromium/src/+/a91f5b16d907a71eb79896a54fc8c368d11dc061 TBR=weiliangc@chromium.org,enne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693740 Review-Url: https://codereview.chromium.org/2830473002 Cr-Commit-Position: refs/heads/master@{#465390} Committed: https://chromium.googlesource.com/chromium/src/+/2501a834815e3a9e460051bd98f1eb49c7357e7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M cc/trees/draw_property_utils.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pdr.
Created Revert of Remove UpdateScrollTree
3 years, 8 months ago (2017-04-18 21:56:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830473002/1
3 years, 8 months ago (2017-04-18 21:57:15 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 21:57:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2501a834815e3a9e460051bd98f1...

Powered by Google App Engine
This is Rietveld 408576698