Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2830453002: [Merge M58] Fix randomly disappearing icons in app list recent view. (Closed)

Created:
3 years, 8 months ago by khmel
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] Fix randomly disappearing icons in app list recent view. This fixes race condition when extension is installed. BUG=711779 TEST=Manually on device. No flikering and no disappearing icons detected. TBR=xiyuan@chromium.org,rdevlin.cronin@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2817293002 Cr-Commit-Position: refs/heads/master@{#464879} (cherry picked from commit 37568714f8eba4d6ff7eaf2257e1a785a80753e6) Review-Url: https://codereview.chromium.org/2830453002 Cr-Commit-Position: refs/branch-heads/3029@{#748} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/116c88cc867c94b284d999e7c7379687cc11c314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M chrome/browser/ui/app_list/search/extension_app_result.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/extension_app_result.cc View 3 chunks +21 lines, -9 lines 0 comments Download
M extensions/browser/extension_icon_image.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830453002/1
3 years, 8 months ago (2017-04-18 23:13:15 UTC) #4
commit-bot: I haz the power
Failed to commit the patch.
3 years, 8 months ago (2017-04-18 23:15:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830453002/1
3 years, 8 months ago (2017-04-18 23:18:27 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 23:19:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/116c88cc867c94b284d999e7c737...

Powered by Google App Engine
This is Rietveld 408576698