Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 2830443007: policy_templates.json: improve caption style (Closed)

Created:
3 years, 8 months ago by Thiemo Nagel
Modified:
3 years, 8 months ago
Reviewers:
emaxx
CC:
chromium-reviews, tnagel+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

policy_templates.json: improve caption style For consistency, remove trailing dots from those captions that have them. BUG=none Review-Url: https://codereview.chromium.org/2830443007 Cr-Commit-Position: refs/heads/master@{#465634} Committed: https://chromium.googlesource.com/chromium/src/+/a79078c894d66ddf908750e1b0f1a749a9b0fb01

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove trailing dots from item captions as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M components/policy/resources/policy_templates.json View 1 15 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Thiemo Nagel
Hi Maksim, could you please take a look at this piece of cleanup? -- Thanks, ...
3 years, 8 months ago (2017-04-19 12:23:56 UTC) #6
emaxx
LGTM with a nit https://codereview.chromium.org/2830443007/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2830443007/diff/1/components/policy/resources/policy_templates.json#newcode8892 components/policy/resources/policy_templates.json:8892: 'caption': '''Let users decide.''', nit: ...
3 years, 8 months ago (2017-04-19 14:27:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830443007/20001
3 years, 8 months ago (2017-04-19 15:36:06 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 16:42:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a79078c894d66ddf908750e1b0f1...

Powered by Google App Engine
This is Rietveld 408576698