Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2830443004: Media Remoting: Style fix for UI. (Closed)

Created:
3 years, 8 months ago by xjz
Modified:
3 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-css, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, rwlbuis, nessy, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Remoting: Style fix for UI. Follow-up CL for media remoting UI. Fixed styles according to the UX designer's comments. Original CL is: https://codereview.chromium.org/2767823002/ BUG=712479 Review-Url: https://codereview.chromium.org/2830443004 Cr-Commit-Position: refs/heads/master@{#465488} Committed: https://chromium.googlesource.com/chromium/src/+/387a67d23d6fb927769b793d322838515e5b3795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M third_party/WebKit/Source/core/css/mediaControls.css View 4 chunks +27 lines, -21 lines 0 comments Download
M third_party/WebKit/public/default_100_percent/blink/mediaremoting_cast.png View Binary file 0 comments Download
M third_party/WebKit/public/default_200_percent/blink/mediaremoting_cast.png View Binary file 0 comments Download

Messages

Total messages: 18 (11 generated)
xjz
kinuko: This is a follow-up CL. Just some style changes required by the designer. PTAL. ...
3 years, 8 months ago (2017-04-19 00:54:33 UTC) #6
kinuko
The test's failing, is it related?
3 years, 8 months ago (2017-04-19 03:03:30 UTC) #9
xjz
On 2017/04/19 03:03:30, kinuko wrote: > The test's failing, is it related? No. Should be ...
3 years, 8 months ago (2017-04-19 03:05:31 UTC) #10
kinuko
On 2017/04/19 03:05:31, xjz wrote: > On 2017/04/19 03:03:30, kinuko wrote: > > The test's ...
3 years, 8 months ago (2017-04-19 03:07:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830443004/20001
3 years, 8 months ago (2017-04-19 03:18:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/387a67d23d6fb927769b793d322838515e5b3795
3 years, 8 months ago (2017-04-19 04:10:54 UTC) #16
mlamouri (slow - plz ping)
3 years, 8 months ago (2017-04-19 08:59:04 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698