Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2830343003: media: Update comment on SessionExpirationUpdateCB (Closed)

Created:
3 years, 8 months ago by xhwang
Modified:
3 years, 8 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Update comment on SessionExpirationUpdateCB Clarify what the base::Time value should be to signal NaN in JS. BUG=616166 TEST=Comment change only. R=jrummell@chromium.org Review-Url: https://codereview.chromium.org/2830343003 Cr-Commit-Position: refs/heads/master@{#466510} Committed: https://chromium.googlesource.com/chromium/src/+/aab90f001ac39ed2fdc19fd81d004d278160db2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/base/content_decryption_module.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
xhwang
3 years, 8 months ago (2017-04-21 17:45:34 UTC) #1
xhwang
jrummell: PTAL
3 years, 8 months ago (2017-04-21 18:09:39 UTC) #3
jrummell
lgtm
3 years, 8 months ago (2017-04-21 20:41:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830343003/1
3 years, 8 months ago (2017-04-22 00:24:42 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 00:30:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aab90f001ac39ed2fdc19fd81d00...

Powered by Google App Engine
This is Rietveld 408576698