Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2830293002: Remove the blink dependency in device unittest. (Closed)

Created:
3 years, 8 months ago by ke.he
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the blink dependency in device unittest. After those device sensors client files are moved from Blink to device sensors client lib, device unittest shouldn't depend on blink any more. BUG = 612322 Review-Url: https://codereview.chromium.org/2830293002 Cr-Commit-Position: refs/heads/master@{#466584} Committed: https://chromium.googlesource.com/chromium/src/+/5539439c9241c6775c78d55040faea200b84b1e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
ke.he
Thanks ortuno@ reminds me this:) Hi, Reilly, PTAL, thanks.
3 years, 8 months ago (2017-04-21 08:11:11 UTC) #6
Reilly Grant (use Gerrit)
lgtm
3 years, 8 months ago (2017-04-21 15:09:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830293002/1
3 years, 8 months ago (2017-04-24 02:02:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5539439c9241c6775c78d55040faea200b84b1e7
3 years, 8 months ago (2017-04-24 03:10:44 UTC) #12
ortuno
3 years, 8 months ago (2017-04-25 23:50:00 UTC) #13
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698