Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2830273003: Add min and max to ExecutionMode enum. (Closed)

Created:
3 years, 8 months ago by ftirelo
Modified:
3 years, 8 months ago
Reviewers:
Joe Mason
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add min and max to ExecutionMode enum. BUG= Review-Url: https://codereview.chromium.org/2830273003 Cr-Commit-Position: refs/heads/master@{#466683} Committed: https://chromium.googlesource.com/chromium/src/+/1ddbcd0c22d5f814f9e9853dc06c54ee38159416

Patch Set 1 #

Total comments: 2

Patch Set 2 : Num values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/chrome_cleaner/public/constants/constants.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ftirelo
3 years, 8 months ago (2017-04-21 22:13:59 UTC) #2
Joe Mason
https://codereview.chromium.org/2830273003/diff/1/components/chrome_cleaner/public/constants/constants.h File components/chrome_cleaner/public/constants/constants.h (right): https://codereview.chromium.org/2830273003/diff/1/components/chrome_cleaner/public/constants/constants.h#newcode120 components/chrome_cleaner/public/constants/constants.h:120: kMax = kPostRebootValidation, Can you use kNumValues (= kPostRebootValidation ...
3 years, 8 months ago (2017-04-24 14:36:15 UTC) #3
ftirelo
PTAL https://codereview.chromium.org/2830273003/diff/1/components/chrome_cleaner/public/constants/constants.h File components/chrome_cleaner/public/constants/constants.h (right): https://codereview.chromium.org/2830273003/diff/1/components/chrome_cleaner/public/constants/constants.h#newcode120 components/chrome_cleaner/public/constants/constants.h:120: kMax = kPostRebootValidation, On 2017/04/24 14:36:15, Joe Mason ...
3 years, 8 months ago (2017-04-24 15:16:12 UTC) #4
Joe Mason
lgtm
3 years, 8 months ago (2017-04-24 15:39:45 UTC) #5
Joe Mason
lgtm
3 years, 8 months ago (2017-04-24 15:39:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830273003/20001
3 years, 8 months ago (2017-04-24 17:14:24 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:09:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1ddbcd0c22d5f814f9e9853dc06c...

Powered by Google App Engine
This is Rietveld 408576698