Remove SurfaceFactory in SurfaceAggregatorPerfTest

Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830203002
Cr-Commit-Position: refs/heads/master@{#466574}
Committed: https://chromium.googlesource.com/chromium/src/+/75e518861ddbdf82531605d1bdf4d678e8d4ffe6

[xing.xu, 2017-04-21 02:31:21]

Description was changed from

==========
Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
==========

to

==========
Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-04-21 02:32:14]

Description was changed from

==========
Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[xing.xu, 2017-04-21 02:32:14]

xing.xu@intel.com changed reviewers:
+ fsamuel@chromium.org, jbauman@chromium.org, staraz@chromium.org

[xing.xu, 2017-04-21 02:32:21]

The CQ bit was checked by xing.xu@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 02:32:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 02:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 02:44:04]

Dry run: This issue passed the CQ dry run.

[xing.xu, 2017-04-21 02:59:20]

PTAL.

[Fady Samuel, 2017-04-21 03:02:33]

lgtm

[Alex Z., 2017-04-21 12:35:13]

LGTM. Thanks for doing this!

[xing.xu, 2017-04-21 14:03:41]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-04-21 14:03:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 14:09:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xing.xu, 2017-04-22 10:56:01]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-04-22 10:56:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 10:58:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 10:58:43]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[xing.xu, 2017-04-22 12:14:22]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-04-22 12:14:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 12:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 12:17:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xing.xu, 2017-04-22 15:05:49]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-04-22 15:06:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 15:09:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 15:09:04]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xing.xu, 2017-04-22 21:37:31]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-04-22 21:37:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 21:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 21:41:02]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2017-04-22 21:48:23]

You're going to need to rebase... That file has changed.

[xing.xu, 2017-04-22 22:53:20]

The CQ bit was checked by xing.xu@intel.com

[xing.xu, 2017-04-22 22:53:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, staraz@chromium.org
Link to the patchset: https://codereview.chromium.org/2830203002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-22 22:53:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xing.xu, 2017-04-22 22:53:40]

On 2017/04/22 21:48:23, Fady Samuel wrote:
> You're going to need to rebase... That file has changed.

Thanks fady! rebase is done.

[commit-bot: I haz the power, 2017-04-22 23:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 23:00:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2017-04-22 23:07:17]

fsamuel@chromium.org changed reviewers:
+ enne@chromium.org
- jbauman@chromium.org

[Fady Samuel, 2017-04-22 23:07:17]

jbauman@ is OOO until Tuesday. Adding enne@ for cc review.

[enne (OOO), 2017-04-23 22:28:17]

lgtm

[xing.xu, 2017-04-24 01:01:35]

The CQ bit was checked by xing.xu@intel.com

[commit-bot: I haz the power, 2017-04-24 01:01:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 01:14:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492995695431420,
"parent_rev": "0380ef0910a520f4336ba3e8d3c6fdcc007e5cee", "commit_rev":
"75e518861ddbdf82531605d1bdf4d678e8d4ffe6"}

[commit-bot: I haz the power, 2017-04-24 01:14:24]

Description was changed from

==========
Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830203002
Cr-Commit-Position: refs/heads/master@{#466574}
Committed:
https://chromium.googlesource.com/chromium/src/+/75e518861ddbdf82531605d1bdf4...
==========

[commit-bot: I haz the power, 2017-04-24 01:14:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75e518861ddbdf82531605d1bdf4...

[xing.xu, 2017-04-24 07:42:17]

If CompositorFrame was not initialized properly, it will DLOG ERROR like this:
ERROR:compositor_frame_sink_support.cc(137)] Received CompositorFrame with
invalid BeginFrameAck.

Will handle this in a follow up cl.

[xing.xu, 2017-04-24 08:52:12]

Description was changed from

==========
Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830203002
Cr-Commit-Position: refs/heads/master@{#466574}
Committed:
https://chromium.googlesource.com/chromium/src/+/75e518861ddbdf82531605d1bdf4...
==========

to

==========
Remove SurfaceFactory in SurfaceAggregatorPerfTest

Also change the size of rect and visible_rect to fix DrawQuad::SetAll checks.

BUG=707105
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830203002
Cr-Commit-Position: refs/heads/master@{#466574}
Committed:
https://chromium.googlesource.com/chromium/src/+/75e518861ddbdf82531605d1bdf4...
==========

[xing.xu, 2017-04-24 08:53:02]

PTAL