Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 283017: Don't delay menu item fixup when the number of tabs change.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac.mm
===================================================================
--- chrome/browser/app_controller_mac.mm (revision 29135)
+++ chrome/browser/app_controller_mac.mm (working copy)
@@ -271,7 +271,11 @@
// Called when the number of tabs changes in one of the browser windows. The
// object is the tab strip controller, but we don't currently care.
- (void)tabsChanged:(NSNotification*)notify {
- [self delayedFixCloseMenuItemKeyEquivalents];
+ // We don't need to do this on a delay, as in the method above, because the
+ // window layering isn't changing. As a result, there's no chance that a
+ // different window will sneak in as the key window and cause the problems
+ // we hacked around above by clearing the key equivalents.
Mark Mentovai 2009/10/16 19:33:20 Ever notice how everyone from Canada sounds like a
+ [self fixCloseMenuItemKeyEquivalents];
}
// If the auto-update interval is not set, make it 5 hours.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698