Don't delay menu item fixup when the number of tabs change....

chrome/browser/app_controller_mac.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/app_controller_mac.h"
 
 #include "app/l10n_util_mac.h"
 #include "base/command_line.h"
 #include "base/mac_util.h"
 #include "base/message_loop.h"
@@ skipping 253 matching lines @@
   [self delayedFixCloseMenuItemKeyEquivalents];
 
   // TODO(pinkerton): If we have other things here, such as inspector panels
   // that follow the contents of the selected webpage, we would update those
   // here.
 }
 
 // Called when the number of tabs changes in one of the browser windows. The
 // object is the tab strip controller, but we don't currently care.
 - (void)tabsChanged:(NSNotification*)notify {
-  [self delayedFixCloseMenuItemKeyEquivalents];
+  // We don't need to do this on a delay, as in the method above, because the
+  // window layering isn't changing. As a result, there's no chance that a
+  // different window will sneak in as the key window and cause the problems
+  // we hacked around above by clearing the key equivalents.

[Mark Mentovai, 2009/10/16 19:33:20]

Ever notice how everyone from Canada sounds like a walrus?

+  [self fixCloseMenuItemKeyEquivalents];
 }
 
 // If the auto-update interval is not set, make it 5 hours.
 // This code is specific to Mac Chrome Dev Channel.
 // Placed here for 2 reasons:
 // 1) Same spot as other Pref stuff
 // 2) Try and be friendly by keeping this after app launch
 // TODO(jrg): remove once we go Beta.
 - (void)setUpdateCheckInterval {
 #if defined(GOOGLE_CHROME_BUILD)
@@ skipping 435 matching lines @@
 @end
 
 //---------------------------------------------------------------------------
 
 // Stub for cross-platform method that isn't called on Mac OS X.
 void ShowOptionsWindow(OptionsPage page,
                        OptionsGroup highlight_group,
                        Profile* profile) {
   NOTIMPLEMENTED();
 }