[merge-m59] Cater for the "double close" when clicking "Learn More" on auto-dismiss extension bubbl…

[merge-m59] Cater for the "double close" when clicking "Learn More" on auto-dismiss extension bubbles.

This fixes a regression from r459382 where clicking a "Learn More" link
on the NTP override bubble can spew out tabs. The problem is that
opening a tab may defocus the bubble, triggering a Close(). The
extension bubble client must still call close since there's no guarantee
that the defocus may trigger a close.

To fix, Close() needs more awareness of whether it is closed via being
deactivated by the user, via being deactivated by the delegate opening a
link, or via being explicitly closed by LinkClicked(). Currently it only
caters for two of these cases. We can more clearly capture the use case
simply by ensuring the delegate is not notified multiple times by
setting a flag.

BUG=712545
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2827603005
Cr-Commit-Position: refs/heads/master@{#466228}
(cherry picked from commit d7340b19e7dd13c8379174ad50ce2c8220637aa7)

Review-Url: https://codereview.chromium.org/2830163003
Cr-Commit-Position: refs/branch-heads/3071@{#144}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/9581bd5192d8ceef1d6d6a02652c990998cfbfd1

[tapted, 2017-04-22 10:22:57]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-04-22 10:23:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 10:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 10:23:11]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[tapted, 2017-04-22 10:23:50]

Description was changed from

==========
[merge-m59] Cater for the "double close" when clicking "Learn More" on
auto-dismiss extension bubbles.

This fixes a regression from r459382 where clicking a "Learn More" link
on the NTP override bubble can spew out tabs. The problem is that
opening a tab may defocus the bubble, triggering a Close(). The
extension bubble client must still call close since there's no guarantee
that the defocus may trigger a close.

To fix, Close() needs more awareness of whether it is closed via being
deactivated by the user, via being deactivated by the delegate opening a
link, or via being explicitly closed by LinkClicked(). Currently it only
caters for two of these cases. We can more clearly capture the use case
simply by ensuring the delegate is not notified multiple times by
setting a flag.

BUG=712545
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2827603005
Cr-Commit-Position: refs/heads/master@{#466228}
(cherry picked from commit d7340b19e7dd13c8379174ad50ce2c8220637aa7)
==========

to

==========
[merge-m59] Cater for the "double close" when clicking "Learn More" on
auto-dismiss extension bubbles.

This fixes a regression from r459382 where clicking a "Learn More" link
on the NTP override bubble can spew out tabs. The problem is that
opening a tab may defocus the bubble, triggering a Close(). The
extension bubble client must still call close since there's no guarantee
that the defocus may trigger a close.

To fix, Close() needs more awareness of whether it is closed via being
deactivated by the user, via being deactivated by the delegate opening a
link, or via being explicitly closed by LinkClicked(). Currently it only
caters for two of these cases. We can more clearly capture the use case
simply by ensuring the delegate is not notified multiple times by
setting a flag.

BUG=712545
NOTRY=true
NOPRESUBMIT=true
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2827603005
Cr-Commit-Position: refs/heads/master@{#466228}
(cherry picked from commit d7340b19e7dd13c8379174ad50ce2c8220637aa7)
==========

[tapted, 2017-04-22 10:24:11]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-04-22 10:24:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-04-22 10:29:18]

The CQ bit was unchecked by tapted@chromium.org

[tapted, 2017-04-22 10:29:54]

Description was changed from

==========
[merge-m59] Cater for the "double close" when clicking "Learn More" on
auto-dismiss extension bubbles.

This fixes a regression from r459382 where clicking a "Learn More" link
on the NTP override bubble can spew out tabs. The problem is that
opening a tab may defocus the bubble, triggering a Close(). The
extension bubble client must still call close since there's no guarantee
that the defocus may trigger a close.

To fix, Close() needs more awareness of whether it is closed via being
deactivated by the user, via being deactivated by the delegate opening a
link, or via being explicitly closed by LinkClicked(). Currently it only
caters for two of these cases. We can more clearly capture the use case
simply by ensuring the delegate is not notified multiple times by
setting a flag.

BUG=712545
NOTRY=true
NOPRESUBMIT=true
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2827603005
Cr-Commit-Position: refs/heads/master@{#466228}
(cherry picked from commit d7340b19e7dd13c8379174ad50ce2c8220637aa7)
==========

to

==========
[merge-m59] Cater for the "double close" when clicking "Learn More" on
auto-dismiss extension bubbles.

This fixes a regression from r459382 where clicking a "Learn More" link
on the NTP override bubble can spew out tabs. The problem is that
opening a tab may defocus the bubble, triggering a Close(). The
extension bubble client must still call close since there's no guarantee
that the defocus may trigger a close.

To fix, Close() needs more awareness of whether it is closed via being
deactivated by the user, via being deactivated by the delegate opening a
link, or via being explicitly closed by LinkClicked(). Currently it only
caters for two of these cases. We can more clearly capture the use case
simply by ensuring the delegate is not notified multiple times by
setting a flag.

BUG=712545
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2827603005
Cr-Commit-Position: refs/heads/master@{#466228}
(cherry picked from commit d7340b19e7dd13c8379174ad50ce2c8220637aa7)
==========

[tapted, 2017-04-22 10:30:01]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-04-22 10:30:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 10:30:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492857001945590, "parent_rev":
"665f902f9616472914a0298e94849c2c0f1d94fe", "commit_rev":
"9581bd5192d8ceef1d6d6a02652c990998cfbfd1"}

[commit-bot: I haz the power, 2017-04-22 10:30:56]

Description was changed from

==========
[merge-m59] Cater for the "double close" when clicking "Learn More" on
auto-dismiss extension bubbles.

This fixes a regression from r459382 where clicking a "Learn More" link
on the NTP override bubble can spew out tabs. The problem is that
opening a tab may defocus the bubble, triggering a Close(). The
extension bubble client must still call close since there's no guarantee
that the defocus may trigger a close.

To fix, Close() needs more awareness of whether it is closed via being
deactivated by the user, via being deactivated by the delegate opening a
link, or via being explicitly closed by LinkClicked(). Currently it only
caters for two of these cases. We can more clearly capture the use case
simply by ensuring the delegate is not notified multiple times by
setting a flag.

BUG=712545
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2827603005
Cr-Commit-Position: refs/heads/master@{#466228}
(cherry picked from commit d7340b19e7dd13c8379174ad50ce2c8220637aa7)
==========

to

==========
[merge-m59] Cater for the "double close" when clicking "Learn More" on
auto-dismiss extension bubbles.

This fixes a regression from r459382 where clicking a "Learn More" link
on the NTP override bubble can spew out tabs. The problem is that
opening a tab may defocus the bubble, triggering a Close(). The
extension bubble client must still call close since there's no guarantee
that the defocus may trigger a close.

To fix, Close() needs more awareness of whether it is closed via being
deactivated by the user, via being deactivated by the delegate opening a
link, or via being explicitly closed by LinkClicked(). Currently it only
caters for two of these cases. We can more clearly capture the use case
simply by ensuring the delegate is not notified multiple times by
setting a flag.

BUG=712545
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=tapted@chromium.org

Review-Url: https://codereview.chromium.org/2827603005
Cr-Commit-Position: refs/heads/master@{#466228}
(cherry picked from commit d7340b19e7dd13c8379174ad50ce2c8220637aa7)

Review-Url: https://codereview.chromium.org/2830163003
Cr-Commit-Position: refs/branch-heads/3071@{#144}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/9581bd5192d8ceef1d6d6a02652c...
==========

[commit-bot: I haz the power, 2017-04-22 10:30:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9581bd5192d8ceef1d6d6a02652c...