Add FrameSinkManagerHost to NoTransportImageTransportFactory.

Add FrameSinkManagerHost to NoTransportImageTransportFactory.

This will allow FrameSinkManagerHost to be used in tests. Most tests
don't actually need the Mojo connection between FrameSinkManager and
MojoFrameSinkManager, so don't establish that connection in
FrameSinkManagerHost constructor.

BUG=657959
Review-Url: https://codereview.chromium.org/2830143002
Cr-Commit-Position: refs/heads/master@{#467173}
Committed: https://chromium.googlesource.com/chromium/src/+/bfc507f8797d610a272dd3dbcf264825b1cc5384

[kylechar, 2017-04-20 21:03:28]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 21:04:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 23:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 23:02:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kylechar, 2017-04-21 13:13:17]

kylechar@chromium.org changed reviewers:
+ fsamuel@chromium.org

[kylechar, 2017-04-21 13:13:18]

fsamuel for components/viz/*

[kylechar, 2017-04-21 13:14:12]

I guess also services/ui/gpu/* and just general review.

[Fady Samuel, 2017-04-21 13:16:31]

This looks reasonable but it looks like you're failing on Android because you're
not connecting? Do we want to DCHECK or is early exit sufficient for tests?

[kylechar, 2017-04-21 13:27:56]

On 2017/04/21 13:16:31, Fady Samuel wrote:
> This looks reasonable but it looks like you're failing on Android because
you're
> not connecting? Do we want to DCHECK or is early exit sufficient for tests?

Right, I forgot to call ConnectToFrameSinkManager() in
compositor_impl_android.cc. I'll upload that but otherwise it shouldn't change
anything.

I think DCHECK is the right thing to do FrameSinkManagerHost. If a test uses
FrameSinkManagerHost then it should actually do the setup (and have things like
a MessageLoop). The DCHECK will cause a crash in the test so it doesn't pass,
which is what we want. This is going to get more complicated when we move
MojoFrameSinkManager to another process of course :)

[kylechar, 2017-04-21 13:27:56]

On 2017/04/21 13:16:31, Fady Samuel wrote:
> This looks reasonable but it looks like you're failing on Android because
you're
> not connecting? Do we want to DCHECK or is early exit sufficient for tests?

Right, I forgot to call ConnectToFrameSinkManager() in
compositor_impl_android.cc. I'll upload that but otherwise it shouldn't change
anything.

I think DCHECK is the right thing to do FrameSinkManagerHost. If a test uses
FrameSinkManagerHost then it should actually do the setup (and have things like
a MessageLoop). The DCHECK will cause a crash in the test so it doesn't pass,
which is what we want. This is going to get more complicated when we move
MojoFrameSinkManager to another process of course :)

[Fady Samuel, 2017-04-21 13:37:54]

lgtm

[kylechar, 2017-04-21 14:18:46]

kylechar@chromium.org changed reviewers:
+ aelias@chromium.org, jbauman@chromium.org

[kylechar, 2017-04-21 14:18:46]

+jbauman for content/browser/compositor/* 
+aelias for content/browser/renderer_host/compositor_impl_android.cc

[aelias_OOO_until_Jul13, 2017-04-21 18:08:55]

lgtm

[Fady Samuel, 2017-04-22 22:02:14]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 22:02:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-04-22 23:09:16]

You might want to add a content/ reviewer like jam@ because both danakj@ and
jbauman@ are out on Monday :(

There's nothing deeply subtle here, and I've already reviewed this so I think
it's OK to ask for a rubberstamp. Thanks!

[commit-bot: I haz the power, 2017-04-22 23:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 23:20:53]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-04-24 20:51:40]

kylechar@chromium.org changed reviewers:
+ jam@chromium.org
- jbauman@chromium.org

[kylechar, 2017-04-24 20:51:41]

-jbauman who's OOO
+jam for content/browser/compositor/*

[jam, 2017-04-24 22:12:12]

On 2017/04/24 20:51:41, kylechar wrote:
> -jbauman who's OOO
> +jam for content/browser/compositor/*

please pick an owner from content/browser/compositor/OWNERS

[kylechar, 2017-04-25 13:18:05]

kylechar@chromium.org changed reviewers:
+ jbauman@chromium.org
- jam@chromium.org

[kylechar, 2017-04-25 13:18:06]

-jam, +jbauman again.

[jbauman, 2017-04-25 20:39:11]

lgtm

[kylechar, 2017-04-25 20:44:56]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[kylechar, 2017-04-25 20:45:08]

Thanks!

[commit-bot: I haz the power, 2017-04-25 20:45:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 21:30:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:30:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kylechar, 2017-04-25 23:47:00]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 23:47:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:03:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:03:26]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-04-26 00:05:58]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:06:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 00:13:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493165158654210,
"parent_rev": "714f3da6005d557c7dff987fb3ee097201cb31fd", "commit_rev":
"bfc507f8797d610a272dd3dbcf264825b1cc5384"}

[commit-bot: I haz the power, 2017-04-26 00:13:49]

Description was changed from

==========
Add FrameSinkManagerHost to NoTransportImageTransportFactory.

This will allow FrameSinkManagerHost to be used in tests. Most tests
don't actually need the Mojo connection between FrameSinkManager and
MojoFrameSinkManager, so don't establish that connection in
FrameSinkManagerHost constructor.

BUG=657959
==========

to

==========
Add FrameSinkManagerHost to NoTransportImageTransportFactory.

This will allow FrameSinkManagerHost to be used in tests. Most tests
don't actually need the Mojo connection between FrameSinkManager and
MojoFrameSinkManager, so don't establish that connection in
FrameSinkManagerHost constructor.

BUG=657959

Review-Url: https://codereview.chromium.org/2830143002
Cr-Commit-Position: refs/heads/master@{#467173}
Committed:
https://chromium.googlesource.com/chromium/src/+/bfc507f8797d610a272dd3dbcf26...
==========

[commit-bot: I haz the power, 2017-04-26 00:13:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bfc507f8797d610a272dd3dbcf26...