Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2830053002: [Web Payments] Correctly use UTF8ToUTF16 on strings from website. (Closed)

Created:
3 years, 8 months ago by anthonyvd
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Correctly use UTF8ToUTF16 on strings from website. BUG=711057 Review-Url: https://codereview.chromium.org/2830053002 Cr-Commit-Position: refs/heads/master@{#466026} Committed: https://chromium.googlesource.com/chromium/src/+/de031ea2c4d1d738d2ac5b8e270af35e1de39bab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/views/payments/payment_request_views_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
anthonyvd
Hi Rouslan, this CL changes ASCIIToUTF16 calls operating on website-originated strings to UTF8ToUTF16. Can you ...
3 years, 8 months ago (2017-04-20 15:07:56 UTC) #2
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-20 15:08:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830053002/1
3 years, 8 months ago (2017-04-20 15:09:10 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 15:51:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de031ea2c4d1d738d2ac5b8e270a...

Powered by Google App Engine
This is Rietveld 408576698