Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2830033004: [ObjC ARC] Converts ios/chrome/browser/ui/icons:icons to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/icons:icons to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2830033004 Cr-Commit-Position: refs/heads/master@{#466037} Committed: https://chromium.googlesource.com/chromium/src/+/3194254dc652c6ca45f7f7b11685ccd03252ea6b

Patch Set 1 #

Patch Set 2 : Fix autorelease #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M ios/chrome/browser/ui/icons/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/icons/chrome_icon.mm View 1 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-20 13:55:40 UTC) #6
sdefresne
lgtm
3 years, 8 months ago (2017-04-20 13:59:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830033004/20001
3 years, 8 months ago (2017-04-20 14:01:26 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 17:15:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3194254dc652c6ca45f7f7b11685...

Powered by Google App Engine
This is Rietveld 408576698