components/policy/core/common/cloud/cloud_policy_validator_unittest.cc - Issue 2830033003: Use {To/From}JavaTime for policy timestamps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

Issue 2830033003: Use {To/From}JavaTime for policy timestamps (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/cloud/cloud_policy_validator.cc ('k') | components/policy/core/common/cloud/component_cloud_policy_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

diff --git a/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc b/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

index ef099c93287a4bcb0f39db37e094a5614e9f3241..1a773e8b7cb7659cc70f06da849a7fae9ea0b4cf 100644

--- a/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

+++ b/components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

@@ -43,9 +43,7 @@ ACTION_P(CheckStatus, expected_status) {

class CloudPolicyValidatorTest : public testing::Test {

public:

CloudPolicyValidatorTest()

- : timestamp_(

- base::Time::UnixEpoch() +

- base::TimeDelta::FromMilliseconds(PolicyBuilder::kFakeTimestamp)),

+ : timestamp_(base::Time::FromJavaTime(PolicyBuilder::kFakeTimestamp)),

timestamp_option_(CloudPolicyValidatorBase::TIMESTAMP_VALIDATED),

dm_token_option_(CloudPolicyValidatorBase::DM_TOKEN_REQUIRED),

device_id_option_(CloudPolicyValidatorBase::DEVICE_ID_REQUIRED),

@@ -214,8 +212,7 @@ TEST_F(CloudPolicyValidatorTest, IgnoreMissingTimestamp) {

TEST_F(CloudPolicyValidatorTest, ErrorOldTimestamp) {

base::Time timestamp(timestamp_ - base::TimeDelta::FromMinutes(5));

- policy_.policy_data().set_timestamp(

- (timestamp - base::Time::UnixEpoch()).InMilliseconds());

+ policy_.policy_data().set_timestamp(timestamp.ToJavaTime());

Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_BAD_TIMESTAMP));

}