Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

Issue 2830033003: Use {To/From}JavaTime for policy timestamps (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/policy/core/common/cloud/cloud_policy_validator.h" 5 #include "components/policy/core/common/cloud/cloud_policy_validator.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 25 matching lines...) Expand all
36 36
37 namespace { 37 namespace {
38 38
39 ACTION_P(CheckStatus, expected_status) { 39 ACTION_P(CheckStatus, expected_status) {
40 EXPECT_EQ(expected_status, arg0->status()); 40 EXPECT_EQ(expected_status, arg0->status());
41 }; 41 };
42 42
43 class CloudPolicyValidatorTest : public testing::Test { 43 class CloudPolicyValidatorTest : public testing::Test {
44 public: 44 public:
45 CloudPolicyValidatorTest() 45 CloudPolicyValidatorTest()
46 : timestamp_( 46 : timestamp_(base::Time::FromJavaTime(PolicyBuilder::kFakeTimestamp)),
47 base::Time::UnixEpoch() +
48 base::TimeDelta::FromMilliseconds(PolicyBuilder::kFakeTimestamp)),
49 timestamp_option_(CloudPolicyValidatorBase::TIMESTAMP_VALIDATED), 47 timestamp_option_(CloudPolicyValidatorBase::TIMESTAMP_VALIDATED),
50 dm_token_option_(CloudPolicyValidatorBase::DM_TOKEN_REQUIRED), 48 dm_token_option_(CloudPolicyValidatorBase::DM_TOKEN_REQUIRED),
51 device_id_option_(CloudPolicyValidatorBase::DEVICE_ID_REQUIRED), 49 device_id_option_(CloudPolicyValidatorBase::DEVICE_ID_REQUIRED),
52 allow_key_rotation_(true), 50 allow_key_rotation_(true),
53 existing_dm_token_(PolicyBuilder::kFakeToken), 51 existing_dm_token_(PolicyBuilder::kFakeToken),
54 existing_device_id_(PolicyBuilder::kFakeDeviceId), 52 existing_device_id_(PolicyBuilder::kFakeDeviceId),
55 owning_domain_(PolicyBuilder::kFakeDomain), 53 owning_domain_(PolicyBuilder::kFakeDomain),
56 cached_key_signature_(PolicyBuilder::GetTestSigningKeySignature()) { 54 cached_key_signature_(PolicyBuilder::GetTestSigningKeySignature()) {
57 policy_.SetDefaultNewSigningKey(); 55 policy_.SetDefaultNewSigningKey();
58 } 56 }
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 } 205 }
208 206
209 TEST_F(CloudPolicyValidatorTest, IgnoreMissingTimestamp) { 207 TEST_F(CloudPolicyValidatorTest, IgnoreMissingTimestamp) {
210 timestamp_option_ = CloudPolicyValidatorBase::TIMESTAMP_NOT_VALIDATED; 208 timestamp_option_ = CloudPolicyValidatorBase::TIMESTAMP_NOT_VALIDATED;
211 policy_.policy_data().clear_timestamp(); 209 policy_.policy_data().clear_timestamp();
212 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_OK)); 210 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_OK));
213 } 211 }
214 212
215 TEST_F(CloudPolicyValidatorTest, ErrorOldTimestamp) { 213 TEST_F(CloudPolicyValidatorTest, ErrorOldTimestamp) {
216 base::Time timestamp(timestamp_ - base::TimeDelta::FromMinutes(5)); 214 base::Time timestamp(timestamp_ - base::TimeDelta::FromMinutes(5));
217 policy_.policy_data().set_timestamp( 215 policy_.policy_data().set_timestamp(timestamp.ToJavaTime());
218 (timestamp - base::Time::UnixEpoch()).InMilliseconds());
219 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_BAD_TIMESTAMP)); 216 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_BAD_TIMESTAMP));
220 } 217 }
221 218
222 TEST_F(CloudPolicyValidatorTest, ErrorNoDMToken) { 219 TEST_F(CloudPolicyValidatorTest, ErrorNoDMToken) {
223 policy_.policy_data().clear_request_token(); 220 policy_.policy_data().clear_request_token();
224 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_BAD_DM_TOKEN)); 221 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_BAD_DM_TOKEN));
225 } 222 }
226 223
227 TEST_F(CloudPolicyValidatorTest, ErrorNoDMTokenNotRequired) { 224 TEST_F(CloudPolicyValidatorTest, ErrorNoDMTokenNotRequired) {
228 // Even though DM tokens are not required, if the existing policy has a token, 225 // Even though DM tokens are not required, if the existing policy has a token,
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 412
416 TEST_F(CloudPolicyValidatorTest, NoRotation) { 413 TEST_F(CloudPolicyValidatorTest, NoRotation) {
417 allow_key_rotation_ = false; 414 allow_key_rotation_ = false;
418 policy_.UnsetNewSigningKey(); 415 policy_.UnsetNewSigningKey();
419 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_OK)); 416 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_OK));
420 } 417 }
421 418
422 } // namespace 419 } // namespace
423 420
424 } // namespace policy 421 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698