Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2830013006: Disable ButterBar in chromoting webapp (Closed)

Created:
3 years, 8 months ago by Sergey Ulanov
Modified:
3 years, 8 months ago
Reviewers:
Jamie, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ButterBar in chromoting webapp BUG=714244 Review-Url: https://codereview.chromium.org/2830013006 Cr-Commit-Position: refs/heads/master@{#466452} Committed: https://chromium.googlesource.com/chromium/src/+/96c22ff94cdd4c7d46c1f50d26879ac1107fe0c0

Patch Set 1 #

Total comments: 2

Patch Set 2 : bug link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M remoting/webapp/crd/js/crd_main.js View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Sergey Ulanov
3 years, 8 months ago (2017-04-21 20:35:21 UTC) #2
Sergey Ulanov
+Joe
3 years, 8 months ago (2017-04-21 20:36:24 UTC) #4
joedow
lgtm https://codereview.chromium.org/2830013006/diff/1/remoting/webapp/crd/js/crd_main.js File remoting/webapp/crd/js/crd_main.js (right): https://codereview.chromium.org/2830013006/diff/1/remoting/webapp/crd/js/crd_main.js#newcode86 remoting/webapp/crd/js/crd_main.js:86: // Butter bar is temporarily disabled. not: Add ...
3 years, 8 months ago (2017-04-21 20:39:10 UTC) #5
Sergey Ulanov
https://codereview.chromium.org/2830013006/diff/1/remoting/webapp/crd/js/crd_main.js File remoting/webapp/crd/js/crd_main.js (right): https://codereview.chromium.org/2830013006/diff/1/remoting/webapp/crd/js/crd_main.js#newcode86 remoting/webapp/crd/js/crd_main.js:86: // Butter bar is temporarily disabled. On 2017/04/21 20:39:09, ...
3 years, 8 months ago (2017-04-21 20:49:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830013006/20001
3 years, 8 months ago (2017-04-21 20:50:17 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 21:35:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96c22ff94cdd4c7d46c1f50d2687...

Powered by Google App Engine
This is Rietveld 408576698