Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2829993002: webkitpy: Prevent the addition of duplicate virtual tests. (Closed)

Created:
3 years, 8 months ago by mithro
Modified:
3 years, 8 months ago
Reviewers:
qyearsley, mcgreevy
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Prevent the addition of duplicate virtual tests. BUG=713525 Review-Url: https://codereview.chromium.org/2829993002 Cr-Commit-Position: refs/heads/master@{#466587} Committed: https://chromium.googlesource.com/chromium/src/+/eaa6185759c3d8f7230851633c724caa73f544e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 2 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mithro
3 years, 8 months ago (2017-04-20 06:25:51 UTC) #2
mcgreevy
lgtm
3 years, 8 months ago (2017-04-20 07:02:25 UTC) #3
qyearsley
lgtm
3 years, 8 months ago (2017-04-20 16:47:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829993002/1
3 years, 8 months ago (2017-04-24 03:05:45 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 04:16:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eaa6185759c3d8f7230851633c72...

Powered by Google App Engine
This is Rietveld 408576698