Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2829963003: MIPS[64]: Skip some WASM SIMD tests (Closed)

Created:
3 years, 8 months ago by dusan.simicic
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Skip some WASM SIMD tests For now skip some WASM SIMD tests that fail when MIPS SIMD extension is not available. Turn on these tests again when simd scalar lowering mechanism supports all WASM SIMD operations. BUG= Review-Url: https://codereview.chromium.org/2829963003 Cr-Commit-Position: refs/heads/master@{#44791} Committed: https://chromium.googlesource.com/v8/v8/+/4764cfb017d9ae47526f7453fd88da6ac3e2f421

Patch Set 1 #

Patch Set 2 : remove refinement tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
dusan.simicic
PTAL
3 years, 8 months ago (2017-04-20 14:22:30 UTC) #2
ivica.bogosavljevic
lgtm, but you will need approval from the file owner
3 years, 8 months ago (2017-04-24 09:29:19 UTC) #4
dusan.simicic
PS2: Removed RecipRefine and RecipSqrtRefine tests because those operations are removed in this CL: https://codereview.chromium.org/2827143002/
3 years, 8 months ago (2017-04-24 09:37:10 UTC) #6
Michael Achenbach
lgtm - stamp
3 years, 8 months ago (2017-04-24 09:45:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829963003/20001
3 years, 8 months ago (2017-04-24 12:43:22 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 12:45:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/4764cfb017d9ae47526f7453fd88da6ac3e...

Powered by Google App Engine
This is Rietveld 408576698