Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: pkg/analysis_server/test/domain_server_test.dart

Issue 282993002: Leave "error" key out of response JSON when there is no error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/domain_context_test.dart ('k') | pkg/analysis_server/test/protocol_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_server_test.dart
diff --git a/pkg/analysis_server/test/domain_server_test.dart b/pkg/analysis_server/test/domain_server_test.dart
index cb63f617b0ac3f7d2e2962771ee595ffcbc197e8..82e8903303c6fede6aeb5072fd63947d76460df6 100644
--- a/pkg/analysis_server/test/domain_server_test.dart
+++ b/pkg/analysis_server/test/domain_server_test.dart
@@ -35,7 +35,7 @@ class ServerDomainHandlerTest {
expect(response.error, isNull);
expect(response.result, isEmpty);
}
-
+
static void createContext_alreadyExists() {
AnalysisServer server = new AnalysisServer(new MockServerChannel());
ServerDomainHandler handler = new ServerDomainHandler(server);
@@ -92,8 +92,7 @@ class ServerDomainHandlerTest {
deleteRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, contextId);
Response response = handler.handleRequest(deleteRequest);
expect(response.toJson(), equals({
- Response.ID: '0',
- Response.ERROR: null
+ Response.ID: '0'
}));
}
@@ -105,8 +104,7 @@ class ServerDomainHandlerTest {
Request shutdownRequest = new Request('0', ServerDomainHandler.SHUTDOWN_METHOD);
Response response = handler.handleRequest(shutdownRequest);
expect(response.toJson(), equals({
- Response.ID: '0',
- Response.ERROR: null
+ Response.ID: '0'
}));
expect(server.running, isFalse);
}
@@ -119,7 +117,6 @@ class ServerDomainHandlerTest {
Response response = handler.handleRequest(versionRequest);
expect(response.toJson(), equals({
Response.ID: '0',
- Response.ERROR: null,
Response.RESULT: {
ServerDomainHandler.VERSION_RESULT: '0.0.1'
}
« no previous file with comments | « pkg/analysis_server/test/domain_context_test.dart ('k') | pkg/analysis_server/test/protocol_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698