Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: pkg/analysis_server/test/domain_server_test.dart

Issue 282993002: Leave "error" key out of response JSON when there is no error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.domain.server; 5 library test.domain.server;
6 6
7 import 'package:analysis_server/src/analysis_server.dart'; 7 import 'package:analysis_server/src/analysis_server.dart';
8 import 'package:analysis_server/src/domain_server.dart'; 8 import 'package:analysis_server/src/domain_server.dart';
9 import 'package:analysis_server/src/protocol.dart'; 9 import 'package:analysis_server/src/protocol.dart';
10 import 'package:unittest/unittest.dart'; 10 import 'package:unittest/unittest.dart';
(...skipping 17 matching lines...) Expand all
28 ServerDomainHandler handler = new ServerDomainHandler(server); 28 ServerDomainHandler handler = new ServerDomainHandler(server);
29 29
30 Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_ METHOD); 30 Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_ METHOD);
31 createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath) ; 31 createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath) ;
32 createRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, 'ctx'); 32 createRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, 'ctx');
33 Response response = handler.handleRequest(createRequest); 33 Response response = handler.handleRequest(createRequest);
34 expect(response.id, equals('0')); 34 expect(response.id, equals('0'));
35 expect(response.error, isNull); 35 expect(response.error, isNull);
36 expect(response.result, isEmpty); 36 expect(response.result, isEmpty);
37 } 37 }
38 38
39 static void createContext_alreadyExists() { 39 static void createContext_alreadyExists() {
40 AnalysisServer server = new AnalysisServer(new MockServerChannel()); 40 AnalysisServer server = new AnalysisServer(new MockServerChannel());
41 ServerDomainHandler handler = new ServerDomainHandler(server); 41 ServerDomainHandler handler = new ServerDomainHandler(server);
42 42
43 Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_ METHOD); 43 Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_ METHOD);
44 createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath) ; 44 createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath) ;
45 createRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, 'ctx'); 45 createRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, 'ctx');
46 Response response = handler.handleRequest(createRequest); 46 Response response = handler.handleRequest(createRequest);
47 expect(response.error, isNull); 47 expect(response.error, isNull);
48 response = handler.handleRequest(createRequest); 48 response = handler.handleRequest(createRequest);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 String contextId = 'ctx'; 85 String contextId = 'ctx';
86 Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_ METHOD); 86 Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_ METHOD);
87 createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath) ; 87 createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath) ;
88 createRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, contextId); 88 createRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, contextId);
89 handler.createContext(createRequest); 89 handler.createContext(createRequest);
90 90
91 Request deleteRequest = new Request('0', ServerDomainHandler.DELETE_CONTEXT_ METHOD); 91 Request deleteRequest = new Request('0', ServerDomainHandler.DELETE_CONTEXT_ METHOD);
92 deleteRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, contextId); 92 deleteRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, contextId);
93 Response response = handler.handleRequest(deleteRequest); 93 Response response = handler.handleRequest(deleteRequest);
94 expect(response.toJson(), equals({ 94 expect(response.toJson(), equals({
95 Response.ID: '0', 95 Response.ID: '0'
96 Response.ERROR: null
97 })); 96 }));
98 } 97 }
99 98
100 static void shutdown() { 99 static void shutdown() {
101 AnalysisServer server = new AnalysisServer(new MockServerChannel()); 100 AnalysisServer server = new AnalysisServer(new MockServerChannel());
102 ServerDomainHandler handler = new ServerDomainHandler(server); 101 ServerDomainHandler handler = new ServerDomainHandler(server);
103 102
104 expect(server.running, isTrue); 103 expect(server.running, isTrue);
105 Request shutdownRequest = new Request('0', ServerDomainHandler.SHUTDOWN_METH OD); 104 Request shutdownRequest = new Request('0', ServerDomainHandler.SHUTDOWN_METH OD);
106 Response response = handler.handleRequest(shutdownRequest); 105 Response response = handler.handleRequest(shutdownRequest);
107 expect(response.toJson(), equals({ 106 expect(response.toJson(), equals({
108 Response.ID: '0', 107 Response.ID: '0'
109 Response.ERROR: null
110 })); 108 }));
111 expect(server.running, isFalse); 109 expect(server.running, isFalse);
112 } 110 }
113 111
114 static void version() { 112 static void version() {
115 AnalysisServer server = new AnalysisServer(new MockServerChannel()); 113 AnalysisServer server = new AnalysisServer(new MockServerChannel());
116 ServerDomainHandler handler = new ServerDomainHandler(server); 114 ServerDomainHandler handler = new ServerDomainHandler(server);
117 115
118 Request versionRequest = new Request('0', ServerDomainHandler.VERSION_METHOD ); 116 Request versionRequest = new Request('0', ServerDomainHandler.VERSION_METHOD );
119 Response response = handler.handleRequest(versionRequest); 117 Response response = handler.handleRequest(versionRequest);
120 expect(response.toJson(), equals({ 118 expect(response.toJson(), equals({
121 Response.ID: '0', 119 Response.ID: '0',
122 Response.ERROR: null,
123 Response.RESULT: { 120 Response.RESULT: {
124 ServerDomainHandler.VERSION_RESULT: '0.0.1' 121 ServerDomainHandler.VERSION_RESULT: '0.0.1'
125 } 122 }
126 })); 123 }));
127 } 124 }
128 } 125 }
OLDNEW
« no previous file with comments | « pkg/analysis_server/test/domain_context_test.dart ('k') | pkg/analysis_server/test/protocol_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698