Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2829923005: Reland of Update V8 to version 6.0.50. (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Update V8 to version 6.0.50. (patchset #1 id:1 of https://codereview.chromium.org/2834783003/ ) Reason for revert: Turned green before revert was in. Original issue's description: > Revert of Update V8 to version 6.0.50. (patchset #1 id:1 of https://codereview.chromium.org/2833753003/ ) > > Reason for revert: > compile failure on chromium/Win x64 > > https://bugs.chromium.org/p/chromium/issues/detail?id=713996 > > Original issue's description: > > Update V8 to version 6.0.50. > > > > Summary of changes available at: > > https://chromium.googlesource.com/v8/v8/+log/ab42a2aa..63c64c6d > > > > Please follow these instructions for assigning/CC'ing issues: > > https://github.com/v8/v8/wiki/Triaging%20issues > > > > Please close rolling in case of a roll revert: > > https://v8-roll.appspot.com/ > > This only works with a Google account. > > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > > > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org > > > > Review-Url: https://codereview.chromium.org/2833753003 > > Cr-Commit-Position: refs/heads/master@{#466258} > > Committed: https://chromium.googlesource.com/chromium/src/+/5ed39274a52c6e34e35e7a9c95aff9ef64a5ca32 > > TBR=hablich@chromium.org,kozyatinskiy@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2834783003 > Cr-Commit-Position: refs/heads/master@{#466267} > Committed: https://chromium.googlesource.com/chromium/src/+/b1294add46cb5b22c5e03ca2ad91db5562c4bf44 TBR=hablich@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org,keishi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=713996 Review-Url: https://codereview.chromium.org/2829923005 Cr-Commit-Position: refs/heads/master@{#466274} Committed: https://chromium.googlesource.com/chromium/src/+/1d9c0272a5d06697b9e633f7140fcbfd7ff2b1fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Michael Achenbach
Created Reland of Update V8 to version 6.0.50.
3 years, 8 months ago (2017-04-21 06:38:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829923005/1
3 years, 8 months ago (2017-04-21 06:38:48 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 06:39:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d9c0272a5d06697b9e633f7140f...

Powered by Google App Engine
This is Rietveld 408576698