Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2829913003:
Change MediaQueryList-001 to test on min-width: 1px (Closed)
|
Created:
3 years, 8 months ago by meade_UTC10 Modified:
3 years, 8 months ago CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Yoav Weiss Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange MediaQueryList-001 to test on min-width: 1px
This is instead of the device aspect ratio, as that is brittle.
BUG=710226
Review-Url: https://codereview.chromium.org/2829913003
Cr-Commit-Position: refs/heads/master@{#466573}
Committed: https://chromium.googlesource.com/chromium/src/+/0380ef0910a520f4336ba3e8d3c6fdcc007e5cee
Patch Set 1 #Patch Set 2 : Change MediaQueryList-001 to test on min-width: 1px instead of the device aspect ratio, as that is … #
Total comments: 2
Patch Set 3 : remove out of date comment #Messages
Total messages: 20 (12 generated)
meade@chromium.org changed reviewers: + qyearsley@chromium.org, simonp@opera.com
PTAL
The CQ bit was checked by meade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
alancutter@chromium.org changed reviewers: + alancutter@chromium.org
I think yoav would be a suitable reviewer for this change. https://codereview.chromium.org/2829913003/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/external/wpt/cssom-view/MediaQueryList-001.html (right): https://codereview.chromium.org/2829913003/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/external/wpt/cssom-view/MediaQueryList-001.html:14: <p>The test passes if the value is 1280/800</p> This comment is now out of date. It probably shouldn't even be a comment since it's just duplicating the test case in untestable English.
Good catch, thanks Alan! https://codereview.chromium.org/2829913003/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/external/wpt/cssom-view/MediaQueryList-001.html (right): https://codereview.chromium.org/2829913003/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/external/wpt/cssom-view/MediaQueryList-001.html:14: <p>The test passes if the value is 1280/800</p> On 2017/04/20 04:23:39, alancutter wrote: > This comment is now out of date. It probably shouldn't even be a comment since > it's just duplicating the test case in untestable English. Removed.
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
LGTM, thanks :-)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rune@opera.com changed reviewers: + rune@opera.com
lgtm
The CQ bit was checked by meade@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
adding yoav to cc as per Alan's comment
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492991867273270,
"parent_rev": "0a5b389d935f65c3f328ac71dedef9d5699cf49b", "commit_rev":
"0380ef0910a520f4336ba3e8d3c6fdcc007e5cee"}
Message was sent while issue was closed.
Description was changed from ========== Change MediaQueryList-001 to test on min-width: 1px This is instead of the device aspect ratio, as that is brittle. BUG=710226 ========== to ========== Change MediaQueryList-001 to test on min-width: 1px This is instead of the device aspect ratio, as that is brittle. BUG=710226 Review-Url: https://codereview.chromium.org/2829913003 Cr-Commit-Position: refs/heads/master@{#466573} Committed: https://chromium.googlesource.com/chromium/src/+/0380ef0910a520f4336ba3e8d3c6... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/0380ef0910a520f4336ba3e8d3c6... |
