Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2829903002:
Add UseFlex(c) for the cloud implementation. (Closed)
|
Created:
3 years, 8 months ago by Ryan Tseng Modified:
3 years, 8 months ago CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org Target Ref:
refs/heads/master Project:
luci-gae Visibility:
Public. |
DescriptionAdd UseFlex(c) for the cloud implementation.
Which installs an Info and Datastore module if the instance is
running on GCE
BUG=698429
Review-Url: https://codereview.chromium.org/2829903002
Committed: https://github.com/luci/gae/commit/da65416c45a996664d23f2bf22299e910e7b0561
Patch Set 1 #Patch Set 2 : Also UseGI #
Total comments: 1
Patch Set 3 : UseFlex #
Messages
Total messages: 27 (19 generated)
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hinoka@chromium.org changed reviewers: + hinoka@chromium.org, vadimsh@chromium.org
ptal, related to https://codereview.chromium.org/2796743004/ (flex log viewer)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add UseInfo(c) for the memory implementation. For when we only need to use the Info module. BUG=698429 ========== to ========== Add UseInfo(c) for the memory implementation. For when we only need to use the Info module. BUG=698429 ==========
vadimsh@chromium.org changed reviewers: + iannucci@chromium.org
https://codereview.chromium.org/2829903002/diff/20001/impl/memory/context.go File impl/memory/context.go (right): https://codereview.chromium.org/2829903002/diff/20001/impl/memory/context.go#... impl/memory/context.go:114: memctx := newMemContext(fqAppID) this thing has mentions of datastore and task queues. "Info" service is, supposedly, unrelated. I'm not sure what will happen if we return half-initialized mem context. I don't know this code very well... I think Robbie should review.
discussed in chat; the ultimate goal is to have a way to use luci/gae from flex; I recommended adding a https://chromium-review.googlesource.com/c/482541/ in impl/cloud, and then refactoring the implementation of GI from impl/memory so impl/cloud can import+install it when the user calls cloud.UseWithAppID.
On 2017/04/20 00:25:18, iannucci wrote: > discussed in chat; the ultimate goal is to have a way to use luci/gae from flex; > I recommended adding a https://chromium-review.googlesource.com/c/482541/ in > impl/cloud, and then refactoring the implementation of GI from impl/memory so > impl/cloud can import+install it when the user calls cloud.UseWithAppID. er... not a random url... adding `UseWithAppID` in cloud.
The CQ bit was checked by hinoka@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add UseInfo(c) for the memory implementation. For when we only need to use the Info module. BUG=698429 ========== to ========== Add UseFlex(c) for the cloud implementation. Which installs an Info and Datastore module if the instance is running on GCE BUG=698429 ==========
newest PS exposes UseFlex from cloud, which uses Info from Memory.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by hinoka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492716965290100,
"parent_rev": "4e7c36ffa6c3a0e4904c3577ac80f8878aa78c28", "commit_rev":
"da65416c45a996664d23f2bf22299e910e7b0561"}
Message was sent while issue was closed.
Description was changed from ========== Add UseFlex(c) for the cloud implementation. Which installs an Info and Datastore module if the instance is running on GCE BUG=698429 ========== to ========== Add UseFlex(c) for the cloud implementation. Which installs an Info and Datastore module if the instance is running on GCE BUG=698429 Review-Url: https://codereview.chromium.org/2829903002 Committed: https://github.com/luci/gae/commit/da65416c45a996664d23f2bf22299e910e7b0561 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://github.com/luci/gae/commit/da65416c45a996664d23f2bf22299e910e7b0561 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
