Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2829873002: Collect media query results for non-matching stylesheets. (Closed)

Created:
3 years, 8 months ago by rune
Modified:
3 years, 8 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Collect media query results for non-matching stylesheets. Viewport and device dependent media query results are collected after an active stylesheet update happen. The results are collected on the ScopedStyleResolvers and propagated to the CSSGlobalRuleSet. It's necessary that the active stylesheet update causes these media query results to be up-to-date so that e.g. a viewport resize checks these results to detect that we need an active stylesheet update for a given resize. That did not happen when we only added sheets for which the media attrbute did not match, because adding a sheet with a null RuleSet does not affect the computed style and the changed_rule_sets set was empty. Now, if we add or remove a sheet which does not apply, and that sheet has a viewport or device dependent media query, still return kActiveSheetsAppended or kActiveSheetsChanged to trigger the re- collection of those media query results. BUG=710878 Review-Url: https://codereview.chromium.org/2829873002 Cr-Commit-Position: refs/heads/master@{#465912} Committed: https://chromium.googlesource.com/chromium/src/+/7a7892d7272ce168b1db7f4da87ae70d5e23cecc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/media-attr-non-matching-dynamic.html View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheets.cpp View 5 chunks +20 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp View 2 chunks +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rune
3 years, 8 months ago (2017-04-19 23:16:06 UTC) #4
meade_UTC10
lgtm lgtm
3 years, 8 months ago (2017-04-20 03:10:46 UTC) #7
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-20 03:10:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829873002/1
3 years, 8 months ago (2017-04-20 06:09:02 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 06:13:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a7892d7272ce168b1db7f4da87a...

Powered by Google App Engine
This is Rietveld 408576698