Remove some illegal enum forward declarations

Remove some illegal enum forward declarations

C++ forbids the forward declaring of enums without specifying a size
because the size is not known. Specifying the size in multiple places is
dangerous. So, this change removes the forward declarations and instead
includes the required header files, except where one case where the
forward declaration is unavoidable.

These problems were found with the C4471 option, enabled with /w14471.

R=jschuh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2829853010
Cr-Commit-Position: refs/heads/master@{#466628}
Committed: https://chromium.googlesource.com/chromium/src/+/a85fa6ea57acf1e6d8b3a13f1dc9b9754c2ec89b

[brucedawson, 2017-04-22 00:04:37]

Description was changed from

==========
Remove some illegal enum forward declarations

C++ forbids the forward declaring of enums without specifying a size
because the size is not known. Specifying the size in multiple places is
dangerous. So, this change removes the forward declarations and instead
includes the required header files.

These problems were found with the C4471 option, enabled with /w14471.

R=jschuh@chromium.org
==========

to

==========
Remove some illegal enum forward declarations

C++ forbids the forward declaring of enums without specifying a size
because the size is not known. Specifying the size in multiple places is
dangerous. So, this change removes the forward declarations and instead
includes the required header files.

These problems were found with the C4471 option, enabled with /w14471.

R=jschuh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[brucedawson, 2017-04-22 00:04:44]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 00:05:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 00:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 00:15:30]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[brucedawson, 2017-04-22 00:37:07]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 00:37:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-04-22 00:39:19]

Description was changed from

==========
Remove some illegal enum forward declarations

C++ forbids the forward declaring of enums without specifying a size
because the size is not known. Specifying the size in multiple places is
dangerous. So, this change removes the forward declarations and instead
includes the required header files.

These problems were found with the C4471 option, enabled with /w14471.

R=jschuh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Remove some illegal enum forward declarations

C++ forbids the forward declaring of enums without specifying a size
because the size is not known. Specifying the size in multiple places is
dangerous. So, this change removes the forward declarations and instead
includes the required header files, except where one case where the
forward declaration is unavoidable.

These problems were found with the C4471 option, enabled with /w14471.

R=jschuh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[commit-bot: I haz the power, 2017-04-22 01:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 01:46:50]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-04-22 22:08:35]

C++ conformance FTW. PTAL

[jschuh, 2017-04-24 13:29:13]

The CQ bit was checked by jschuh@chromium.org

[jschuh, 2017-04-24 13:29:14]

lgtm

[commit-bot: I haz the power, 2017-04-24 13:29:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 14:21:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493040553635700,
"parent_rev": "6edb4adf96be1878dd2721dafac9d15dde07669c", "commit_rev":
"a85fa6ea57acf1e6d8b3a13f1dc9b9754c2ec89b"}

[commit-bot: I haz the power, 2017-04-24 14:21:24]

Description was changed from

==========
Remove some illegal enum forward declarations

C++ forbids the forward declaring of enums without specifying a size
because the size is not known. Specifying the size in multiple places is
dangerous. So, this change removes the forward declarations and instead
includes the required header files, except where one case where the
forward declaration is unavoidable.

These problems were found with the C4471 option, enabled with /w14471.

R=jschuh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Remove some illegal enum forward declarations

C++ forbids the forward declaring of enums without specifying a size
because the size is not known. Specifying the size in multiple places is
dangerous. So, this change removes the forward declarations and instead
includes the required header files, except where one case where the
forward declaration is unavoidable.

These problems were found with the C4471 option, enabled with /w14471.

R=jschuh@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2829853010
Cr-Commit-Position: refs/heads/master@{#466628}
Committed:
https://chromium.googlesource.com/chromium/src/+/a85fa6ea57acf1e6d8b3a13f1dc9...
==========

[commit-bot: I haz the power, 2017-04-24 14:21:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a85fa6ea57acf1e6d8b3a13f1dc9...