Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2829853006: bluetooth: Match real ReadRemoteCharacteristic's behavior (Closed)

Created:
3 years, 8 months ago by ortuno
Modified:
3 years, 8 months ago
Reviewers:
scheib
CC:
chromium-reviews, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, ortuno+watch_chromium.org, Peter Beverloo, scheib+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Match real ReadRemoteCharacteristic's behavior BluetoothRemoteGattCharacteristic::ReadRemoteCharacteristic used to dispatch an GattCharacteristicValueChanged event once a characteristic was read. This side effect was removed but our fakes were not changed. This patch stops calling GattCharacteristicValueChanged after read operations. BUG=713984 Review-Url: https://codereview.chromium.org/2829853006 Cr-Commit-Position: refs/heads/master@{#466276} Committed: https://chromium.googlesource.com/chromium/src/+/abe917c952a135427bec96cd62d8b7c174d79734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -65 lines) Patch
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 5 chunks +8 lines, -65 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ortuno
scheib: PTAL
3 years, 8 months ago (2017-04-21 04:34:55 UTC) #4
scheib
lgtm
3 years, 8 months ago (2017-04-21 06:34:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829853006/1
3 years, 8 months ago (2017-04-21 06:47:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 06:52:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/abe917c952a135427bec96cd62d8...

Powered by Google App Engine
This is Rietveld 408576698