Convert constructor/periodicwave.html to use new Audit

Convert constructor/periodicwave.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/periodicwave.html

Review-Url: https://codereview.chromium.org/2829853005
Cr-Commit-Position: refs/heads/master@{#468780}
Committed: https://chromium.googlesource.com/chromium/src/+/989c0769083cd9dd898eb5f3c7ba9993d3877cd9

[Raymond Toy, 2017-04-26 14:58:10]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-26 14:58:11]

PTAL

[hongchan, 2017-04-28 18:38:22]

I believe this test could use some more refactoring.

https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html
(right):

https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:139:
function(length, freq, sampleRate) {
These on-the-fly functions can be refactored somehow? WDYT?

https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:218:
function waveTest(should, waveOptions, expectedFunction, threshold) {
Well the function name could be more descriptive.

Add a comment above the function definition, not below.

https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:262: //
Verify that the default PeriodicWave produces a sine wave. Use a
Move this comment above the function definition.

[Raymond Toy, 2017-04-28 20:00:34]

On 2017/04/28 at 18:38:22, hongchan wrote:
> I believe this test could use some more refactoring.
> 
>
https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html
(right):
> 
>
https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:139:
function(length, freq, sampleRate) {
> These on-the-fly functions can be refactored somehow? WDYT?
> 
>
https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:218:
function waveTest(should, waveOptions, expectedFunction, threshold) {
> Well the function name could be more descriptive.
> 
> Add a comment above the function definition, not below.
> 
>
https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:262: //
Verify that the default PeriodicWave produces a sine wave. Use a
> Move this comment above the function definition.

Unlike the other tests where we could simplify things greatly by using the new
test functions, we're not doing that here, so I'd prefer not to refactor them. 
The purpose of this CL is the conversion to new Audit.

[hongchan, 2017-05-02 16:37:15]

lgtm 

'll leave it up to you - but can you file a bug so we know that this file needs
refactoring?

[Raymond Toy, 2017-05-02 18:52:41]

https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html
(right):

https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:139:
function(length, freq, sampleRate) {
On 2017/04/28 18:38:22, hongchan wrote:
> These on-the-fly functions can be refactored somehow? WDYT?

Done.

https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:218:
function waveTest(should, waveOptions, expectedFunction, threshold) {
On 2017/04/28 18:38:22, hongchan wrote:
> Well the function name could be more descriptive.
> 
> Add a comment above the function definition, not below.

Done.

https://codereview.chromium.org/2829853005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/periodicwave.html:262: //
Verify that the default PeriodicWave produces a sine wave. Use a
On 2017/04/28 18:38:22, hongchan wrote:
> Move this comment above the function definition.

Done.

[Raymond Toy, 2017-05-02 18:52:51]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-05-02 18:52:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2829853005/#ps60001
(title: "Address review comments.")

[commit-bot: I haz the power, 2017-05-02 18:53:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 21:30:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493751171372400,
"parent_rev": "86ccfebb8d4cd066b640d742e6dcd6043cf04cf4", "commit_rev":
"989c0769083cd9dd898eb5f3c7ba9993d3877cd9"}

[commit-bot: I haz the power, 2017-05-02 21:30:25]

Description was changed from

==========
Convert constructor/periodicwave.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/periodicwave.html
==========

to

==========
Convert constructor/periodicwave.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/periodicwave.html

Review-Url: https://codereview.chromium.org/2829853005
Cr-Commit-Position: refs/heads/master@{#468780}
Committed:
https://chromium.googlesource.com/chromium/src/+/989c0769083cd9dd898eb5f3c7ba...
==========

[commit-bot: I haz the power, 2017-05-02 21:30:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/989c0769083cd9dd898eb5f3c7ba...