Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2829853003: Remove crufty bridge code from old CRD iOS app. (Closed)

Created:
3 years, 8 months ago by nicholss
Modified:
3 years, 8 months ago
Reviewers:
joedow
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove crufty bridge code from old CRD iOS app. Moved the app to use the new render in remoting, so this code is no longer needed. R=joedow@chromium.org BUG=671692 Review-Url: https://codereview.chromium.org/2829853003 Cr-Commit-Position: refs/heads/master@{#466109} Committed: https://chromium.googlesource.com/chromium/src/+/8c4b1490ea9281f0cd6189d2f79ebc3f97e74ad3

Patch Set 1 #

Patch Set 2 : Remove non-dependent change for removing bridge. #

Patch Set 3 : Fix remoting/display proto import issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2477 lines) Patch
M remoting/client/display/BUILD.gn View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M remoting/client/ios/BUILD.gn View 1 3 chunks +0 lines, -4 lines 0 comments Download
M remoting/client/ios/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/client/ios/bridge/BUILD.gn View 1 chunk +0 lines, -93 lines 0 comments Download
D remoting/client/ios/bridge/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D remoting/client/ios/bridge/client_instance.h View 1 chunk +0 lines, -204 lines 0 comments Download
D remoting/client/ios/bridge/client_instance.cc View 1 chunk +0 lines, -363 lines 0 comments Download
D remoting/client/ios/bridge/client_instance_unittest.mm View 1 chunk +0 lines, -328 lines 0 comments Download
D remoting/client/ios/bridge/client_proxy.h View 1 chunk +0 lines, -68 lines 0 comments Download
D remoting/client/ios/bridge/client_proxy.mm View 1 chunk +0 lines, -155 lines 0 comments Download
D remoting/client/ios/bridge/client_proxy_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
D remoting/client/ios/bridge/client_proxy_delegate_wrapper.h View 1 chunk +0 lines, -33 lines 0 comments Download
D remoting/client/ios/bridge/client_proxy_delegate_wrapper.mm View 1 chunk +0 lines, -31 lines 0 comments Download
D remoting/client/ios/bridge/client_proxy_unittest.mm View 1 chunk +0 lines, -372 lines 0 comments Download
D remoting/client/ios/bridge/frame_consumer_bridge.h View 1 chunk +0 lines, -62 lines 0 comments Download
D remoting/client/ios/bridge/frame_consumer_bridge.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D remoting/client/ios/bridge/frame_consumer_bridge_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D remoting/client/ios/bridge/host_proxy.h View 1 chunk +0 lines, -68 lines 0 comments Download
D remoting/client/ios/bridge/host_proxy.mm View 1 chunk +0 lines, -116 lines 0 comments Download
D remoting/client/ios/bridge/host_proxy_unittest.mm View 1 chunk +0 lines, -51 lines 0 comments Download
M remoting/client/ios/display/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/client/ios/utility.h View 1 chunk +0 lines, -105 lines 0 comments Download
D remoting/client/ios/utility.mm View 1 chunk +0 lines, -173 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
nicholss
PTAL
3 years, 8 months ago (2017-04-19 23:51:43 UTC) #7
joedow
lgtm Excellent! lgtm
3 years, 8 months ago (2017-04-20 01:49:44 UTC) #12
joedow
lgtm Excellent! lgtm
3 years, 8 months ago (2017-04-20 01:49:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829853003/40001
3 years, 8 months ago (2017-04-20 20:20:12 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 20:26:23 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8c4b1490ea9281f0cd6189d2f79e...

Powered by Google App Engine
This is Rietveld 408576698