Remove buffer size sanity check from URLRequestJob::Read

Remove buffer size sanity check from URLRequestJob::Read

BUG=713358
Review-Url: https://codereview.chromium.org/2829833002
Cr-Commit-Position: refs/heads/master@{#465881}
Committed: https://chromium.googlesource.com/chromium/src/+/2375f72a0c62be56a6cb80fd2daff66c7748fda4

[kapishnikov, 2017-04-19 21:17:59]

The CQ bit was checked by kapishnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 21:19:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kapishnikov, 2017-04-19 21:19:27]

kapishnikov@chromium.org changed reviewers:
+ mmenke@chromium.org, xunjieli@chromium.org

[kapishnikov, 2017-04-19 21:19:28]

Removed the check. PTAL.

[kapishnikov, 2017-04-19 21:19:43]

The CQ bit was checked by kapishnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 21:20:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-04-19 21:20:54]

On 2017/04/19 21:19:28, kapishnikov wrote:
> Removed the check. PTAL.

lgtm. I am fine with removing the DCHECK. Andrei's arguments make sense.
Please wait for mmenke@'s stamp though.

[mmenke, 2017-04-19 21:40:18]

On 2017/04/19 21:20:54, xunjieli wrote:
> On 2017/04/19 21:19:28, kapishnikov wrote:
> > Removed the check. PTAL.
> 
> lgtm. I am fine with removing the DCHECK. Andrei's arguments make sense.
> Please wait for mmenke@'s stamp though.

LGTM.  If we had more direct URLRequest consumers, I'd push back on this, and
suggest having cronet only pass in a subset of the buffer, if it's larger, but
given that we only have a couple consumers, this seems fine.

[mmenke, 2017-04-19 21:40:19]

On 2017/04/19 21:20:54, xunjieli wrote:
> On 2017/04/19 21:19:28, kapishnikov wrote:
> > Removed the check. PTAL.
> 
> lgtm. I am fine with removing the DCHECK. Andrei's arguments make sense.
> Please wait for mmenke@'s stamp though.

LGTM.  If we had more direct URLRequest consumers, I'd push back on this, and
suggest having cronet only pass in a subset of the buffer, if it's larger, but
given that we only have a couple consumers, this seems fine.

[commit-bot: I haz the power, 2017-04-19 22:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 22:24:17]

Dry run: This issue passed the CQ dry run.

[kapishnikov, 2017-04-20 03:08:21]

The CQ bit was checked by kapishnikov@chromium.org

[commit-bot: I haz the power, 2017-04-20 03:08:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 03:12:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492657701286290, "parent_rev":
"d8adf4fbe2475512e378443279017eadfd0dc68a", "commit_rev":
"2375f72a0c62be56a6cb80fd2daff66c7748fda4"}

[commit-bot: I haz the power, 2017-04-20 03:13:55]

Description was changed from

==========
Remove buffer size sanity check from URLRequestJob::Read

BUG=713358
==========

to

==========
Remove buffer size sanity check from URLRequestJob::Read

BUG=713358

Review-Url: https://codereview.chromium.org/2829833002
Cr-Commit-Position: refs/heads/master@{#465881}
Committed:
https://chromium.googlesource.com/chromium/src/+/2375f72a0c62be56a6cb80fd2daf...
==========

[commit-bot: I haz the power, 2017-04-20 03:13:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2375f72a0c62be56a6cb80fd2daf...