Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: ui/views/controls/textfield/textfield.h

Issue 2829823002: [Textfield] Consider select all status for select all context menu (Closed)
Patch Set: Add test for empty text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/textfield/textfield.cc » ('j') | ui/views/controls/textfield/textfield.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.h
diff --git a/ui/views/controls/textfield/textfield.h b/ui/views/controls/textfield/textfield.h
index 358a248140cdc44189647f8c7eadb290a17c55cf..acb71b46205ad8f2b5484bd96072749602287561 100644
--- a/ui/views/controls/textfield/textfield.h
+++ b/ui/views/controls/textfield/textfield.h
@@ -105,6 +105,9 @@ class VIEWS_EXPORT Textfield : public View,
// of text that overflows its display area.
void SelectAll(bool reversed);
+ // Return false when text is empty.
Peter Kasting 2017/04/20 00:08:30 Nit: "Returns whether all the text is currently se
simonhong 2017/04/20 13:11:51 Removed.
+ bool IsAllSelected() const;
Peter Kasting 2017/04/20 00:08:30 Nit: Does this need to be public? If we're only u
simonhong 2017/04/20 13:11:51 Making it public is mistake. At first, I added as
+
// A convenience method to select the word closest to |point|.
void SelectWordAt(const gfx::Point& point);
« no previous file with comments | « no previous file | ui/views/controls/textfield/textfield.cc » ('j') | ui/views/controls/textfield/textfield.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698